Skip to content

[Windows] Fix pull to refresh w/ horz item layouts - #23547

Merged
Foda merged 4 commits into
mainfrom
foda/PullToRefresh
Jul 17, 2024
Merged

[Windows] Fix pull to refresh w/ horz item layouts#23547
Foda merged 4 commits into
mainfrom
foda/PullToRefresh

Conversation

@Foda

@Foda Foda commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

Description of Change

Switch to use ScrollMode.Enabled when setting horz scroll mode so that pull to refresh works when items view isn't long enough to show scrollbar

Issues Fixed

Fixes #23529

…hat pull to refresh works when items view isn't long enough to show scrollbar
@Foda Foda added platform/windows area-controls-general General issues that span multiple controls, or common base classes such as View or Element labels Jul 10, 2024
@Foda
Foda requested a review from PureWeen July 10, 2024 20:35
@Foda
Foda requested a review from a team as a code owner July 10, 2024 20:35
@Foda
Foda requested a review from mattleibow July 10, 2024 20:35
@PureWeen

Copy link
Copy Markdown
Member

/rebase

…hat pull to refresh works when items view isn't long enough to show scrollbar
@github-actions
github-actions Bot force-pushed the foda/PullToRefresh branch from 26d3796 to 4eaa2fa Compare July 16, 2024 10:10
@Redth

Redth commented Jul 16, 2024

Copy link
Copy Markdown
Member

LGTM... Tested a few scenarios with a touch screen windows machine and working as expected.

@Foda
Foda merged commit 307941e into main Jul 17, 2024
@Foda
Foda deleted the foda/PullToRefresh branch July 17, 2024 20:03
@samhouts samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-8.0.80 and removed fixed-in-net9.0-nightly This may be available in a nightly release! labels Aug 2, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-general General issues that span multiple controls, or common base classes such as View or Element fixed-in-8.0.80 fixed-in-net9.0-nightly This may be available in a nightly release! platform/windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MAUI]I7_PullToRefresh-Pulling down to refresh using refreshview for Horizontal grid doesn't work.

4 participants