enable css for StackBase, remove for StackLayout - #22419
Merged
mattleibow merged 3 commits intoMay 17, 2024
Merged
Conversation
Contributor
|
Hey there @Giviruk! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
This is my first PR, I will try to fix the errors as soon as possible |
jsuarezruiz
reviewed
May 15, 2024
jsuarezruiz
left a comment
jsuarezruiz
left a comment
Contributor
There was a problem hiding this comment.
There are some errors and cannot pass the build:
D:\a\_work\1\s\src\Controls\src\Core\Properties\AssemblyInfo.cs(158,83): error CS0117: 'StackBase' does not contain a definition for 'OrientationProperty' [D:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net8.0-windows10.0.19041.0]
C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.5.240311000\buildTransitive\Microsoft.UI.Xaml.Markup.Compiler.interop.targets(841,9): error MSB3073: The command ""C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.5.240311000\buildTransitive\..\tools\net6.0\..\net472\XamlCompiler.exe" "D:\a\_work\1\s\artifacts\obj\Controls.Core\Release\net8.0-windows10.0.19041.0\\input.json" "D:\a\_work\1\s\artifacts\obj\Controls.Core\Release\net8.0-windows10.0.19041.0\\output.json"" exited with code 1. [D:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net8.0-windows10.0.19041.0]
D:\a\_work\1\s\src\Controls\src\Core\Properties\AssemblyInfo.cs(158,83): error CS0117: 'StackBase' does not contain a definition for 'OrientationProperty' [D:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net8.0-tizen]
D:\a\_work\1\s\src\Controls\src\Core\Properties\AssemblyInfo.cs(158,83): error CS0117: 'StackBase' does not contain a definition for 'OrientationProperty' [D:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net8.0-windows10.0.20348.0]
C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.5.240311000\buildTransitive\Microsoft.UI.Xaml.Markup.Compiler.interop.targets(841,9): error MSB3073: The command ""C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.5.240311000\buildTransitive\..\tools\net6.0\..\net472\XamlCompiler.exe" "D:\a\_work\1\s\artifacts\obj\Controls.Core\Release\net8.0-windows10.0.20348.0\\input.json" "D:\a\_work\1\s\artifacts\obj\Controls.Core\Release\net8.0-windows10.0.20348.0\\output.json"" exited with code 1. [D:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net8.0-windows10.0.20348.0]
11 Error(s)
Let me know if can help with something :)
Contributor
Author
|
does StackBase need OrientationProperty support, the task only talked about SpacingProperty? |
Contributor
Author
|
I looked and saw that the vertical layout and horizontal layout do not have OrientationProperty, so I returned OrientationProperty for StackLayout and left SpacingProperty for StackBase |
mattleibow
reviewed
May 15, 2024
mattleibow
approved these changes
May 15, 2024
Member
|
/azp run |
mattleibow
enabled auto-merge (squash)
May 15, 2024 14:56
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
can someone explain this problem with the code or something else? |
Member
|
something weird happened and navigation stopped working in just 1 test. Retrying. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable css for StackBase for issue #21843