-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Updated build instructions #5534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,6 +38,9 @@ if($env:Platform) { | |
| function Print-Usage() { | ||
| Write-Host "Common settings:" | ||
| Write-Host " -configuration <value> Build configuration: 'Debug' or 'Release' (short: -c)" | ||
| Write-Host " 'Debug', 'Release' (for .NET Core 2.1)" | ||
| Write-Host " 'Debug-netcoreapp3_1', 'Release-netcoreapp3_1' (for .NET Core 3.1)" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Files in eng/common are copied directly from Arcade. The next time we take an Arcade update, they are likely to be overwritten. So it is not a good idea to put these changes here. Can you please find a different mechanism?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That is true. I have also explained the list of available configurations in our developer guide here. Would that not be enough, or should we always have the list of available configs printed out during
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In general, we should probably move away from the custom configurations and instead use "normal" multi-targeting, (i.e. We used custom configurations in the past because that's how build-tools required it to be. Now that we are using arcade, and a typical .NET build system, we should be able to only have
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Got it. Done. |
||
| Write-Host " 'Debug-netfx', 'Release-netfx' (for .NET Frameworks 4.6.1)" | ||
| Write-Host " -platform <value> Platform configuration: 'x86', 'x64' or any valid Platform value to pass to msbuild" | ||
| Write-Host " -verbosity <value> Msbuild verbosity: q[uiet], m[inimal], n[ormal], d[etailed], and diag[nostic] (short: -v)" | ||
| Write-Host " -binaryLog Output binary log (short: -bl)" | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.