Update several links

CODE_OF_CONDUCT.md

@@ -40,7 +40,7 @@ Project maintainers who do not follow or enforce the Code of Conduct in good fai
 
 ## Attribution
 
-This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [http://contributor-covenant.org/version/1/4][version]
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [https://contributor-covenant.org/version/1/4][version]
 
-[homepage]: http://contributor-covenant.org
-[version]: http://contributor-covenant.org/version/1/4/
+[homepage]: https://contributor-covenant.org
+[version]: https://contributor-covenant.org/version/1/4/

DEVGUIDE.md

@@ -5,7 +5,7 @@
 Get the latest source code from the master branch by running this git command:
 
     git clone https://github.com/dotnet/fsharp.git
-    
+
 Before running the build scripts, ensure that you have cleaned up the visualfsharp repo by running this git command:
 
     git clean -xfd
@@ -104,9 +104,9 @@ Or hard crash on launch ("Unknown Error"), delete these folders:
 
 The new builds of the Visual F# IDE Tools can no longer be installed into Visual Studio 2015.
 
-You can install Visual Studio 2019 from https://www.visualstudio.com/downloads/.
+You can install Visual Studio 2019 from <https://www.visualstudio.com/downloads/>.
 
-**Note:** This step will install a VSIX extension into Visual Studio "Next" that changes the Visual F# IDE Tools 
+**Note:** This step will install a VSIX extension into Visual Studio "Next" that changes the Visual F# IDE Tools
 components installed in that VS installation.  You can revert this step by disabling or uninstalling the addin.
 
 For **Debug**, uninstall then reinstall:
@@ -157,25 +157,25 @@ See the "Debugging The Compiler" section of this [article](https://medium.com/@w
 
 ## Notes
 
-#### Windows: Links to  Additional frameworks
+### Windows: Links to  Additional frameworks
 
-- [Git for windows](http://msysgit.github.io/)
-- [.NET 4.6](http://www.microsoft.com/en-us/download/details.aspx?id=48137)
-- [Windows 8.1 SDK](http://msdn.microsoft.com/en-us/library/windows/desktop/bg162891.aspx)
+- [Git for windows](https://gitforwindows.org/)
+- [.NET 4.6](https://www.microsoft.com/en-us/download/details.aspx?id=48137)
+- [Windows 8.1 SDK](https://msdn.microsoft.com/en-us/library/windows/desktop/bg162891.aspx)
 - [Windows 10 SDK](https://developer.microsoft.com/en-US/windows/downloads/windows-10-sdk)
 
-#### Notes on the Windows .NET Framework build
+### Notes on the Windows .NET Framework build
 
 1. The `update.cmd` script adds required strong name validation skips and NGens the compiler and libraries. This requires admin privileges.
 1. The compiler binaries produced are "private" and strong-named signed with a test key.
 1. Some additional tools are required to build the compiler, notably `fslex.exe`, `fsyacc.exe`, `FSharp.PowerPack.Build.Tasks.dll`, `FsSrGen.exe`, `FSharp.SRGen.Build.Tasks.dll`, and the other tools found in the `lkg` directory.
 1. The overall bootstrapping process executes as follows
- - We first need an existing F# compiler. We use the one in the `lkg` directory. Let's assume this compiler has an `FSharp.Core.dll` with version X.
- - We use this compiler to compile the source in this distribution, to produce a "proto" compiler, dropped to the `proto` directory. When run, this compiler still relies on `FSharp.Core.dll` with version X.
- - We use the proto compiler to compile the source for `FSharp.Core.dll` in this distribution.
- - We use the proto compiler to compile the source for `FSharp.Compiler.dll`, `fsc.exe`, `fsi.exe`, and other binaries found in this distribution.
+   - We first need an existing F# compiler. We use the one in the `lkg` directory. Let's assume this compiler has an `FSharp.Core.dll` with version X.
+   - We use this compiler to compile the source in this distribution, to produce a "proto" compiler, dropped to the `proto` directory. When run, this compiler still relies on `FSharp.Core.dll` with version X.
+   - We use the proto compiler to compile the source for `FSharp.Core.dll` in this distribution.
+   s- We use the proto compiler to compile the source for `FSharp.Compiler.dll`, `fsc.exe`, `fsi.exe`, and other binaries found in this distribution.
 
-#### Updating FSComp.fs, FSComp.resx and XLF
+### Updating FSComp.fs, FSComp.resx and XLF
 
 If your changes involve modifying the list of language keywords in any way, (e.g. when implementing a new keyword), the XLF localization files need to be synced with the corresponding resx files. This can be done automatically by running
 
@@ -185,7 +185,7 @@ If your changes involve modifying the list of language keywords in any way, (e.g
 
 This only works on Windows/.NETStandard framework, so changing this from any other platform requires editing and syncing all of the XLF files manually.
 
-#### Configuring proxy server
+### Configuring proxy server
 
 If you are behind a proxy server, NuGet client tool must be configured to use it:
 
@@ -195,6 +195,6 @@ If you are behind a proxy server, NuGet client tool must be configured to use it
 
 Where you should set proper proxy address, user name and password.
 
-#### Resources
+### Resources
 
-The primary technical guide to the core compiler code is [The F# Compiler Technical Guide](http://fsharp.github.io/2015/09/29/fsharp-compiler-guide.html).  Please read and contribute to that guide.
+The primary technical guide to the core compiler code is [The F# Compiler Technical Guide](https://fsharp.github.io/2015/09/29/fsharp-compiler-guide.html).  Please read and contribute to that guide.

README.md

@@ -65,7 +65,7 @@ These are the branches in use:
 
 * `dev15.9`
   - Long-term servicing branch for VS 2017 update 15.9.x. We do not expect to service that release, but if we do, that's where the changes will go.
-  
+
 * `dev16.x`
   - Latest release branch for the particular point release of Visual Studio.
   - Incorporates features and fixes from master up to a particular branch point, then selective cherry-picks.
@@ -84,20 +84,20 @@ Evolution of the F# language and core library follows a process spanning two add
 
 The following links can help you get an overview of some technical aspects of the F# language and compiler:
 
-* [The F# Compiler Technical Guide](http://fsharp.github.io/2015/09/29/fsharp-compiler-guide.html) 
-* [The F# Language Specification](http://fsharp.org/specs/language-spec/)
+* [The F# Compiler Technical Guide](https://fsharp.github.io/2015/09/29/fsharp-compiler-guide.html)
+* [The F# Language Specification](https://fsharp.org/specs/language-spec/)
 
 ## License
 
 This project is subject to the MIT License. A copy of this license is in [License.txt](License.txt).
 
 ## Code of Conduct
 
-This project has adopted the [Contributor Covenant](http://contributor-covenant.org/) code of conduct to clarify expected behavior in our community. You can read it at [CODE_OF_CONDUCT](CODE_OF_CONDUCT.md).
+This project has adopted the [Contributor Covenant](https://contributor-covenant.org/) code of conduct to clarify expected behavior in our community. You can read it at [CODE_OF_CONDUCT](CODE_OF_CONDUCT.md).
 
 ## Get In Touch
 
-Members of the [F# Software Foundation](http://fsharp.org) are invited to the [FSSF Slack](http://fsharp.org/guides/slack/). You can find support from other contributors in the `#compiler` and `#editor-support` channels.
+Members of the [F# Software Foundation](https://fsharp.org) are invited to the [FSSF Slack](https://fsharp.org/guides/slack/). You can find support from other contributors in the `#compiler` and `#editor-support` channels.
 
 Additionally, you can use the `#fsharp` tag on Twitter if you have general F# questions, including about this repository. Chances are you'll get multiple responses.
 
@@ -107,5 +107,5 @@ If you're curious about F# itself, check out these links:
 
 * [What is F#](https://docs.microsoft.com/dotnet/fsharp/what-is-fsharp)
 * [Get started with F#](https://docs.microsoft.com/dotnet/fsharp/get-started/)
-* [F# Software Foundation](http://fsharp.org)
-* [F# Testimonials](http://fsharp.org/testimonials)
+* [F# Software Foundation](https://fsharp.org)
+* [F# Testimonials](https://fsharp.org/testimonials)

eng/common/post-build/sourcelink-validation.ps1

@@ -11,13 +11,13 @@ Set-StrictMode -Version 2.0
 
 . $PSScriptRoot\..\tools.ps1
 
-# Cache/HashMap (File -> Exist flag) used to consult whether a file exist 
+# Cache/HashMap (File -> Exist flag) used to consult whether a file exist
 # in the repository at a specific commit point. This is populated by inserting
 # all files present in the repo at a specific commit point.
 $global:RepoFiles = @{}
 
 $ValidatePackage = {
-  param( 
+  param(
     [string] $PackagePath                                 # Full path to a Symbols.NuGet package
   )
 
@@ -32,7 +32,7 @@ $ValidatePackage = {
   # Extensions for which we'll look for SourceLink information
   # For now we'll only care about Portable & Embedded PDBs
   $RelevantExtensions = @(".dll", ".exe", ".pdb")
- 
+
   Write-Host -NoNewLine "Validating" ([System.IO.Path]::GetFileName($PackagePath)) "... "
 
   $PackageId = [System.IO.Path]::GetFileNameWithoutExtension($PackagePath)
@@ -46,13 +46,13 @@ $ValidatePackage = {
   try {
     $zip = [System.IO.Compression.ZipFile]::OpenRead($PackagePath)
 
-    $zip.Entries | 
+    $zip.Entries |
       Where-Object {$RelevantExtensions -contains [System.IO.Path]::GetExtension($_.Name)} |
         ForEach-Object {
           $FileName = $_.FullName
           $Extension = [System.IO.Path]::GetExtension($_.Name)
           $FakeName = -Join((New-Guid), $Extension)
-          $TargetFile = Join-Path -Path $ExtractPath -ChildPath $FakeName 
+          $TargetFile = Join-Path -Path $ExtractPath -ChildPath $FakeName
 
           # We ignore resource DLLs
           if ($FileName.EndsWith(".resources.dll")) {
@@ -62,7 +62,7 @@ $ValidatePackage = {
           [System.IO.Compression.ZipFileExtensions]::ExtractToFile($_, $TargetFile, $true)
 
           $ValidateFile = {
-            param( 
+            param(
               [string] $FullPath,                                # Full path to the module that has to be checked
               [string] $RealPath,
               [ref] $FailedFiles
@@ -83,15 +83,15 @@ $ValidatePackage = {
                   ForEach-Object {
                     $Link = $_
                     $CommitUrl = "https://raw.githubusercontent.com/${using:GHRepoName}/${using:GHCommit}/"
-                    
+
                     $FilePath = $Link.Replace($CommitUrl, "")
                     $Status = 200
                     $Cache = $using:RepoFiles
 
                     if ( !($Cache.ContainsKey($FilePath)) ) {
                       try {
                         $Uri = $Link -as [System.URI]
-                      
+
                         # Only GitHub links are valid
                         if ($Uri.AbsoluteURI -ne $null -and ($Uri.Host -match "github" -or $Uri.Host -match "githubusercontent")) {
                           $Status = (Invoke-WebRequest -Uri $Link -UseBasicParsing -Method HEAD -TimeoutSec 5).StatusCode
@@ -128,15 +128,15 @@ $ValidatePackage = {
               }
             }
           }
-        
+
           &$ValidateFile $TargetFile $FileName ([ref]$FailedFiles)
         }
   }
   catch {
-  
+
   }
   finally {
-    $zip.Dispose() 
+    $zip.Dispose()
   }
 
   if ($FailedFiles -eq 0) {
@@ -163,13 +163,13 @@ function ValidateSourceLinkLinks {
     ExitWithExitCode 1
   }
 
-  $RepoTreeURL = -Join("http://api.github.com/repos/", $GHRepoName, "/git/trees/", $GHCommit, "?recursive=1")
+  $RepoTreeURL = -Join("https://api.github.com/repos/", $GHRepoName, "/git/trees/", $GHCommit, "?recursive=1")
   $CodeExtensions = @(".cs", ".vb", ".fs", ".fsi", ".fsx", ".fsscript")
 
   try {
     # Retrieve the list of files in the repo at that particular commit point and store them in the RepoFiles hash
     $Data = Invoke-WebRequest $RepoTreeURL -UseBasicParsing | ConvertFrom-Json | Select-Object -ExpandProperty tree
-  
+
     foreach ($file in $Data) {
       $Extension = [System.IO.Path]::GetExtension($file.path)
 
@@ -183,7 +183,7 @@ function ValidateSourceLinkLinks {
     Write-Host $_
     ExitWithExitCode 1
   }
-  
+
   if (Test-Path $ExtractPath) {
     Remove-Item $ExtractPath -Force -Recurse -ErrorAction SilentlyContinue
   }

fcs/README.md

@@ -1,5 +1,3 @@
-
-
 # The FSharp.Compiler.Service components and NuGet package
 
 This directory contains the build, packaging, test and documentation-generation logic for the NuGet package ``FSharp.Compiler.Service``.  The source for this NuGet
@@ -11,7 +9,7 @@ Basically we are packaging up the compiler as a DLL and publishing it as a NuGet
 
 There are subtle differences between FSharp.Compiler.Service and FSharp.Compiler.Private (shipped with the Visual F# Tools)
 
-- FCS has a public API 
+- FCS has a public API
 
 - FCS is built against **.NET 4.6.1** and **FSharp.Core NuGet 4.6.2** to give broader reach
 
@@ -64,10 +62,9 @@ which does things like:
 You can push the packages if you have permissions, either automatically using ``build Release`` or manually
 
     set APIKEY=...
-    ..\fsharp\.nuget\nuget.exe push %HOMEDRIVE%%HOMEPATH%\Downloads\FSharp.Compiler.Service.22.0.3.nupkg %APIKEY% -Source https://nuget.org 
+    ..\fsharp\.nuget\nuget.exe push %HOMEDRIVE%%HOMEPATH%\Downloads\FSharp.Compiler.Service.22.0.3.nupkg %APIKEY% -Source https://nuget.org
     ..\fsharp\.nuget\nuget.exe push %HOMEDRIVE%%HOMEPATH%\Downloads\FSharp.Compiler.Service.MSBuild.v12.22.0.3.nupkg %APIKEY%  -Source https://nuget.org
     ..\fsharp\.nuget\nuget.exe push %HOMEDRIVE%%HOMEPATH%\Downloads\FSharp.Compiler.Service.ProjectCracker.22.0.3.nupkg %APIKEY%  -Source https://nuget.org
-
 
 ### Use of Paket and FAKE
 
@@ -77,23 +74,21 @@ FAKE is only used to run build.fsx.  Eventually we will likely remove this once
 
 ### Testing
 
-Testing reuses the test files from ..\tests\service which were are also FCS tests. 
-
+Testing reuses the test files from ..\tests\service which were are also FCS tests.
 
 ### Documentation Generation
 
     fcs\build GenerateDocs
 
-Output is in ``docs``.  In the ``FSharp.Compiler.Service`` repo this is checked in and hosted as http://fsharp.github.io/FSharp.Compiler.Service.
-
+Output is in ``docs``.  In the ``FSharp.Compiler.Service`` repo this is checked in and hosted as <https://fsharp.github.io/FSharp.Compiler.Service>.
 
 ## The two other NuGet packages
 
-It also contains both the source, build, packaging and test logic for 
+It also contains both the source, build, packaging and test logic for
 
-* ``FSharp.Compiler.Service.MSBuild.v12`` adds legacy MSBuild v12 support to an instance of FSharp.Compiler.Service, if exact compatibility for scripting references such as ``#r "Foo, Version=1.3.4"`` is required. 
+- ``FSharp.Compiler.Service.MSBuild.v12`` adds legacy MSBuild v12 support to an instance of FSharp.Compiler.Service, if exact compatibility for scripting references such as ``#r "Foo, Version=1.3.4"`` is required.
 
-* ``FSharp.Compiler.Service.ProjectCracker`` is part of ``FsAutoComplete`` and Ionide and is used to crack old-style project formats using MSBuild. It used to be part of the FCS API.
+- ``FSharp.Compiler.Service.ProjectCracker`` is part of ``FsAutoComplete`` and Ionide and is used to crack old-style project formats using MSBuild. It used to be part of the FCS API.
 
 Both of these components are gradually becoming obsolete
 
@@ -102,8 +97,7 @@ Both of these components are gradually becoming obsolete
 FSharp.Compiler.Service is a somewhat awkward component. There are some things we can do to simplify things:
 
 1. Remove the use of Paket and FAKE
-1. Move all projects under fcs\... to new .NET SDK project file format 
+1. Move all projects under fcs\... to new .NET SDK project file format
 1. Drop the use of ``dotnet mergenupkg`` since we should be able to use cross targeting
 1. Make FCS a DLL similar ot the rest of the build and make this an official component from Microsoft (signed etc.)
 1. Replace FSharp.Compiler.Private by FSharp.Compiler.Service
-