Skip to content

List.transpose should throw error when given jagged array (#6908)#6989

Merged
TIHan merged 2 commits into
dotnet:masterfrom
PatrickMcDonald:transpose-fix
Jun 27, 2019
Merged

List.transpose should throw error when given jagged array (#6908)#6989
TIHan merged 2 commits into
dotnet:masterfrom
PatrickMcDonald:transpose-fix

Conversation

@PatrickMcDonald

Copy link
Copy Markdown
Contributor
  • transpose does not throw when one of the elements is empty

Fixes #6908

* transpose does not throw when one of the elements is empty

@cartermp cartermp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TIHan TIHan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well.

@TIHan TIHan merged commit 6af64a7 into dotnet:master Jun 27, 2019
@TIHan

TIHan commented Jun 27, 2019

Copy link
Copy Markdown
Contributor

Thanks for your work and patience.

@PatrickMcDonald

Copy link
Copy Markdown
Contributor Author

👍 Always a pleasure!

@PatrickMcDonald PatrickMcDonald deleted the transpose-fix branch June 28, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List.transpose discards data instead of throwing an exception

4 participants