Skip to content

add deterministic to msbuild targets#6363

Merged
KevinRansom merged 2 commits into
dotnet:masterfrom
ctaggart:deterministic
Apr 24, 2019
Merged

add deterministic to msbuild targets#6363
KevinRansom merged 2 commits into
dotnet:masterfrom
ctaggart:deterministic

Conversation

@ctaggart

Copy link
Copy Markdown
Contributor

I was trying to make a deterministic build and noticed the flag wasn't being passed to fsc. Untested, but should get ya'll started.

@ctaggart

Copy link
Copy Markdown
Contributor Author

It compiles now, but the build gurus will need to take this further. The work-a-round is

<OtherFlags>--deterministic+</OtherFlags>

@saul

saul commented Mar 22, 2019

Copy link
Copy Markdown
Contributor

—deterministic+ doesn’t produce deterministic builds - see my PR here #5801

@KevinRansom KevinRansom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@KevinRansom KevinRansom reopened this Apr 22, 2019
@KevinRansom

Copy link
Copy Markdown
Contributor

Thanks for this.

@KevinRansom KevinRansom merged commit f52f4b5 into dotnet:master Apr 24, 2019
@ctaggart ctaggart deleted the deterministic branch April 24, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants