Skip to content

support customizing logo and favicon - #892

Merged
superyyrrzz merged 2 commits into
dotnet:devfrom
superyyrrzz:logo
Nov 18, 2016
Merged

support customizing logo and favicon#892
superyyrrzz merged 2 commits into
dotnet:devfrom
superyyrrzz:logo

Conversation

@superyyrrzz

Copy link
Copy Markdown
Contributor

@hellosnow

Copy link
Copy Markdown
Contributor

:shipit:

@roji

roji commented Nov 14, 2016

Copy link
Copy Markdown
Member

This is great, but note that it still imposes class="svg" (I'm not sure what that means in your CSS and whether it's possible to put in a png etc.).

One idea, probably in addition to this PR, is to extract the logo into its own separate partial, allowing people to override it with whatever they want without having to duplicate the rest of the navbar.

@superyyrrzz

Copy link
Copy Markdown
Contributor Author

@roji We use svg class to provide hover effect in docfx.css. Putting a png here can also work. BTW, it's nice to have a logo partial.

@ansyral

ansyral commented Nov 15, 2016

Copy link
Copy Markdown
Contributor

:shipit:

@superyyrrzz
superyyrrzz merged commit 8fc36f2 into dotnet:dev Nov 18, 2016
@superyyrrzz
superyyrrzz deleted the logo branch November 18, 2016 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants