Skip to content

Enable requesting retry/reboot on Windows XHarness workloads#7983

Merged
premun merged 5 commits into
dotnet:mainfrom
premun:prvysoky/android-retry
Oct 4, 2021
Merged

Enable requesting retry/reboot on Windows XHarness workloads#7983
premun merged 5 commits into
dotnet:mainfrom
premun:prvysoky/android-retry

Conversation

@premun

@premun premun commented Oct 1, 2021

Copy link
Copy Markdown
Member

Following the same pattern we already have on Apple, this should help the MonoVM team react to infrastructure failures inside of their Xunit tests (dotnet/runtime#59679)

Also added new capability to allow setting a reason message via the .retry/.reboot file content

@premun
premun requested a review from fanyang-mono October 1, 2021 10:20
Comment thread src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner/xharness-helix-job.apple.sh Outdated
@lpatalas

lpatalas commented Oct 1, 2021

Copy link
Copy Markdown
Contributor

One question because I'm not familiar with the rest of the code - if we reboot the machine then are those .retry and .reboot files deleted somehow?

@premun

premun commented Oct 1, 2021

Copy link
Copy Markdown
Member Author

@lpatalas
One question because I'm not familiar with the rest of the code - if we reboot the machine then are those .retry and .reboot files deleted somehow?

Yes, they are part of the work item directory which is removed at the end of the work item.

@premun
premun requested a review from MattGal October 1, 2021 11:27
@premun premun changed the title Enable requesting retry/reboot via files on Windows XHarness workloads Enable requesting retry/reboot on Windows XHarness workloads Oct 4, 2021
@premun
premun merged commit ef01d47 into dotnet:main Oct 4, 2021
@premun
premun deleted the prvysoky/android-retry branch October 4, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants