Update the script to include symbolExclusion file#7952
Merged
Conversation
michellemcdaniel
suggested changes
Sep 23, 2021
michellemcdaniel
approved these changes
Sep 24, 2021
michellemcdaniel
left a comment
michellemcdaniel
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Let's make sure this is fully tested in the staging pipeline, but I'm happy
Member
Author
|
Yep running some dotnet-release build.. Once that passes I will merge this.. |
Co-authored-by: Michelle McDaniel <adiaaida@gmail.com>
…into symb-validation
|
Hello @epananth! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To double check:
In symbol-validation we need a param to SymbolExclusionfile. This will help us exclude the files which were not published and just skip them.