Skip to content

Fix typo in mac installer generation script#7917

Merged
ericstj merged 1 commit into
mainfrom
sfoslund/MacScriptFix
Sep 20, 2021
Merged

Fix typo in mac installer generation script#7917
ericstj merged 1 commit into
mainfrom
sfoslund/MacScriptFix

Conversation

@sfoslund

Copy link
Copy Markdown
Member

No description provided.

@sfoslund
sfoslund requested a review from ericstj September 20, 2021 16:12
var archScriptContent = @"<![CDATA[
function IsX64Machine() {
var machine = system.sysctl(""hw.foo"");
var machine = system.sysctl(""hw.machine"");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we have proof our fallback code works if mac were to ever stop reporting this sysctl.

@ericstj
ericstj merged commit f959b45 into main Sep 20, 2021
@sfoslund
sfoslund deleted the sfoslund/MacScriptFix branch September 20, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants