Skip to content

Also set NUGET enhanced environment variables in MSBuild-Core()#7916

Merged
MattGal merged 1 commit into
dotnet:mainfrom
MattGal:msbuild-core-nuget-variables
Sep 20, 2021
Merged

Also set NUGET enhanced environment variables in MSBuild-Core()#7916
MattGal merged 1 commit into
dotnet:mainfrom
MattGal:msbuild-core-nuget-variables

Conversation

@MattGal

@MattGal MattGal commented Sep 20, 2021

Copy link
Copy Markdown
Member

https://github.com/dotnet/core-eng/issues/13691 continuation; the problem can happen during toolset restore, where we don't have the variables set. Also turns on logging that the set occurred for future log reading.

To double check:

@dougbu dougbu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@MattGal
MattGal merged commit 5df4f90 into dotnet:main Sep 20, 2021
@MattGal

MattGal commented Sep 20, 2021

Copy link
Copy Markdown
Member Author

I verified that the variables are now in the ToolSetRestore.binlog file.

jakubstilec pushed a commit to jakubstilec/arcade that referenced this pull request Sep 21, 2021
jakubstilec pushed a commit that referenced this pull request Sep 22, 2021
…etting so we can also do it in MSBuild-Core() (#7916) (#7921)

Co-authored-by: Matt Galbraith <MattGal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants