Add publishing to the dotnetbuilds storage account alongside dotnetcli by alexperovich · Pull Request #7877 · dotnet/arcade

alexperovich · 2021-09-10T00:00:22Z

dotnet/core-eng#14095

To double check:

The right tests are in and and the right validation has happened. Guidance: https://github.com/dotnet/core-eng/tree/master/Documentation/Validation

ChadNedzlek · 2021-09-10T00:10:37Z

            var path = TestInputs.GetFullPath("Symbol");
            var buildAsset = new Dictionary<string, HashSet<Asset>>();
-            var publish = task.HandleSymbolPublishingAsync(path, MsdlToken, SymWebToken, "", false, buildAsset, null, path);
+            await task.HandleSymbolPublishingAsync(path, MsdlToken, SymWebToken, "", false, buildAsset, null, path);


That's... troubling. :-)

ChadNedzlek · 2021-09-10T00:13:27Z

+
+        protected AssetPublisher(TaskLoggingHelper log)
+        {
+            Log = log;


Why not just let the base classes handle this if they want? Rather than forcing everyone to call base(log)?

This abstract class isn't really adding any functionality that an interface with the single "PublishAssetAsync" doesn't provide.

All of the implementations needed it, and calling base(log) isn't really difficult. An interface would play nicer with DI if we do it in the future, so I will change it.

ChadNedzlek · 2021-09-10T00:15:39Z

+            {
+                Log.LogError(
+                    $"Azure DevOps NuGetFeed was not in the expected format '{PublishingConstants.AzDoNuGetFeedPattern}'");
+                return;


You can... return from a constructor? Is that... wise? This feels like it should throw, since nothing later has anything like "did the complete normally" which is a weird thing to have to ask.

Yea, you can return. This is this way because it was that way where I moved it from, but it should 100% be a throw, I will change it.

ChadNedzlek · 2021-09-10T00:16:27Z

+
+        protected override void Dispose(bool disposing)
+        {
+            _httpClient?.Dispose();


This needs to only happen in "disposing==true". If it's fale, the _httpClient might already be GC'd. (antoher reason maybe having the base class isn't a good idea.

ChadNedzlek · 2021-09-10T00:18:44Z

+            {
+                var localMD5 = CalculateMD5(file);
+                var blobMD5 = Convert.ToBase64String(properties.ContentHash);
+                return blobMD5.Equals(localMD5, StringComparison.OrdinalIgnoreCase);


Technically this isn't correct. Just because two files have the same MD5 has doesn't mean they are the same file.

But if the risk of false passes is acceptable, that's fine. Though a comment explaining why a false positive here is considered "ok" is a good idea.

I'm not 100% sure why it was considered okay, but I assume we didn't want publishing to take hours comparing every file byte-for-byte. This is mostly copied from the place it was originally. @mmitche do we care about these collisions?

Right, that was the intention. Avoid very costly download and comparisons. This was based on the content hash being available. That said, I am not sure whether it's ever actually been reliably available. I'm okay with removing this code, or perhaps sticking a bit of telemetry to determine whether we actually hit this code path

ChadNedzlek · 2021-09-10T00:24:59Z

+            }
+
+            int bytesPerMegabyte = 1 * 1024 * 1024;
+            if (properties.ContentLength < bytesPerMegabyte)


Do we need this special case? The other code basically degenerates into exactly this in this case. Seems like it's better to only have 1 thing to maintain/test. :-)

This is just another thing I moved and fixed up a bit. I can remove this case.

ChadNedzlek · 2021-09-10T00:27:04Z

            };
        }
+
+        private string FixUpSasTokenForMSBuildEscaping(string uriWithSas)


This somewhat concerning... why are we accepting incorrect inputs? Why aren't people escaping things correctly?

This also hard codes a lot of assumptions about SAS's. (like that "sig" always comes before "se"), which seems really fragile.

This is fixing up msbuild property escaping issues. If you assign a value containing url encoded things to a property, msbuild will un-encode them before passing them to a task. This is fine for things that aren't already urls, but this value is a url with %2B and %2F all over the query string.

Would re-escaping everything after the ? be less fragile?

ITaskItem2 does proper escaping, I believe (https://docs.microsoft.com/en-us/dotnet/api/microsoft.build.framework.itaskitem2?view=msbuild-16-netcore). Could we somehow utilize that?

As noted above, we should use base64 SAS for this, like we do for the read SAS's that we use to access internally built runtimes.

ChadNedzlek · 2021-09-10T00:27:54Z

+            {
+                return null;
+            }
+            uriWithSas = TransformSection(uriWithSas, "sig=", "&se=", section => section.Replace("+", "%2B").Replace("/", "%2F").Replace("=", "%3D"));


Can't we just "end" at "&", aka "fixup this parameter""?

Is there a reason not to "fix" all the parameters?

Probably not, I will do that.

I have to parse the query string to do this. I was trying to avoid that.

ugh.... HttpUtility.ParseQueryString does partial re-encoding, so this is way more work. The real solution is to not have this publishing stuff be an msbuild task, it gains nothing from msbuild other than logging.

michellemcdaniel · 2021-09-10T04:19:52Z

I am oof tomorrow but back Monday. Is really like a chance to test this in the staging pipeline before it goes in, so please give me a chance to review before it goes in!

mmitche · 2021-09-10T22:04:18Z

I should be able to take a look at this on Monday

michellemcdaniel · 2021-09-13T20:20:30Z

I am having a hard time parsing out some of the logic without like.... stepping through it, so I will just ask:

In the staging pipeline, we use the feed overrides so that we can publish to dotnetstage (like you are publishing to dotnetbuilds in this change). We want to only publish to dotnetstage/the feed overrides in the staging pipeline. How does your change manage that? Is there a way to tell it "if AllowFeedOverrides is true, do NOT upload to dotnetbuilds"? If there isn't, there needs to be, or our logic will begin failing, trying to publish newly signed blobs that have already been published as unsigned to dotnetbuilds, which would be a conflict.

Oh, I think I'm seeing how you're doing this now: you only add in the dotnetbuilds publishing if the feed matches the "default" feed. So if someone has passed in an override, it will not match the PublishingConstants feed uri, and it won't add dotnetbuilds. Is that correct?

alexperovich · 2021-09-13T20:43:05Z

Yes, that is correct. I add the dotnetbuilds things when we are publishing to the standard place.

mmitche · 2021-09-13T21:11:05Z

+            {
+                case FeedType.AzDoNugetFeed:
+                    return new AzureDevOpsNugetFeedAssetPublisher(_log, feedConfig.TargetURL, feedConfig.Token, task);
+                case FeedType.AzureStorageFeed:


I believe this can be removed (maybe just stick an NYI in the case). We should not be publishing using Sleet any longer.

FeedType.AzureStorageFeed == publishing to dotnetcli, I don't think we can remove that. Unless the code does very different things than from what I interpreted.

Hmm..I thought that was "AzureStorageContainer".

AzureStorageContainer is the new one I made, that uses a SAS token to publish, AzureStorageFeed is the old thing that looks and smells like sleet, but just strips the index.json off the end and publishes blobs like normal. It uses the account key.

Okay. Can you do a quick refactor on the AzureStorageFeed enum name to be more indicative of its purpose?

mmitche · 2021-09-13T21:13:48Z

+
+            _httpClient = new HttpClient(new HttpClientHandler {CheckCertificateRevocationList = true})
+            {
+                Timeout = TimeSpan.FromSeconds(300),


Can you hoist this constant out (and other similar constants). We've had to update these a few times in the past and its never easy to actually find which ones to change.

mmitche · 2021-09-13T21:22:56Z

+                return;
+            }
+
+            using var packageReader = new PackageArchiveReader(file);


You should wrap this {} and scope appropriately. I seem to remember changing this specifically a while back for either performance or correctness reasons. IIRC, PackageArchiveReader took an exclusive lock on the file, and depending on disposal time (since in this configuration the scope goes to the end of the method), we got occasional lock issues.

Anyways, scoping down to the minimal required scope is also good practice.

mmitche · 2021-09-13T21:25:15Z

+                var blobClient = CreateBlobClient(blobPath);
+                if (!options.AllowOverwrite && await blobClient.ExistsAsync())
+                {
+                    if (options.PassIfExistingItemIdentical)


I think this option can be just removed at this point.

Its set to true in all cases I can see, so I don't see how we can remove it.

I mean remove the conditional altogether. I don't see us ever passing false for this.

mmitche · 2021-09-13T21:54:34Z

+                                DotNetBuildsPublicUri,
+                                FeedType.AzureStorageContainer,
+                                null,
+                                latestLinkShortUrlPrefix: LatestLinkShortUrlPrefix,


I think this will lead to the aka.ms link pointing to either dotnetcli or dotnetbuilds, depending on what finishes first.

mmitche · 2021-09-13T21:55:21Z

    /// </summary>
    public class TargetFeedConfig
    {
+        public string SafeTargetURL => new UriBuilder(TargetURL) {Query = "", Fragment = ""}.Uri.AbsoluteUri;


Can you add a comment as to what "SafeTargetUrl" means and why it's configured this way? What problem does this solve?

It strips the secret part of the url so we can log it, I will add a comment.

mmitche · 2021-09-13T21:59:29Z

      UseStreamingPublishing="$(UseStreamingPublishing)"
      StreamingPublishingMaxClients="$(StreamingPublishingMaxClients)"
-      NonStreamingPublishingMaxClients="$(NonStreamingPublishingMaxClients)"/>
+      NonStreamingPublishingMaxClients="$(NonStreamingPublishingMaxClients)"


When the feed overrides are present, we should write a test that ensures that an asset is only pushed to a target endpoint once. In the new configuration here, there are multiple target feed configs for an installer blob, for instance. That might cause a bad interaction when the target is overridden to be a specific feed.

alexperovich · 2021-09-13T22:13:07Z

Is this your most recent test run of the promotion pipeline: https://dev.azure.com/dnceng/internal/_build/results?buildId=1351104&view=logs&j=ba23343f-f710-5af9-782d-5bd26b102304&t=6e277ba4-1c1e-552d-b96f-db0aeb4be20a ?

Yes, it looks like it. It has a tweak I added though to skip the dotnetcli publishing part so I didn't mess up normal stuff with my changes.

michellemcdaniel · 2021-09-13T22:28:53Z

Is this your most recent test run of the promotion pipeline: https://dev.azure.com/dnceng/internal/_build/results?buildId=1351104&view=logs&j=ba23343f-f710-5af9-782d-5bd26b102304&t=6e277ba4-1c1e-552d-b96f-db0aeb4be20a ?

Yes, it looks like it. It has a tweak I added though to skip the dotnetcli publishing part so I didn't mess up normal stuff with my changes.

If you do it with arcade (promote arcade with your changes), you can publish to general testing, and not mess anything up. I'd honestly like to see what happens when it publishes to both.

mmitche · 2021-09-14T15:01:23Z

        public const string SnupkgPackageSuffix = ".snupkg";
        public const string PackageSuffix = ".nupkg";
        public const string PackagesCategory = "PACKAGE";
+        public static TimeSpan NugetFeedPublisherHttpClientTimeout => TimeSpan.FromSeconds(300);


Suggested change

public static TimeSpan NugetFeedPublisherHttpClientTimeout => TimeSpan.FromSeconds(300);

public readonly static TimeSpan NugetFeedPublisherHttpClientTimeout = TimeSpan.FromSeconds(300);

alexperovich · 2021-09-14T21:54:45Z

This build has these changes running in a full flow https://dev.azure.com/dnceng/internal/_build/results?buildId=1360392&view=logs&j=ba23343f-f710-5af9-782d-5bd26b102304&t=6e277ba4-1c1e-552d-b96f-db0aeb4be20a

alexperovich · 2021-09-14T21:56:56Z

it only actually published one thing to dotnetbuilds because arcade doesn't produce any non-packages, but it did publish the manifest there.

mmitche · 2021-09-28T15:10:27Z

-                AkaMSTenant = this.AkaMSTenant,
-                BuildQuality = this.BuildQuality,
-            };
+            Log.LogError("V2 Publishing is no longer supported.");


mmitche · 2021-09-28T16:07:05Z

+        {
+            (TargetFeedContentType.Package, FeedDotNet31InternalShipping, AssetSelection.ShippingOnly),
+            (TargetFeedContentType.Package, FeedDotNet31InternalTransport, AssetSelection.NonShippingOnly),
+            (InstallersAndSymbols, FeedInternalForInstallers),


We might need to tweak darc for publishing the internal symbols to the storage account. Issue would be something like it not appending a SAS token when trying to access them.

The thing to test is probably to assign a random, previously unpromoted build of arcade to the "General Testing Internal" channel, then use darc gather-drop on it.

I have one ready, i'll run that.

mmitche · 2021-09-28T16:18:54Z

+            ImmutableList<string> filesToExclude = null,
            bool flatten = true) 
-            : base(isInternalBuild, isStableBuild, repositoryName, commitSha, azureStorageTargetFeedPAT, publishInstallersAndChecksums, installersTargetStaticFeed, installersAzureAccountKey, checksumsTargetStaticFeed, checksumsAzureAccountKey, azureDevOpsStaticShippingFeed, azureDevOpsStaticTransportFeed, azureDevOpsStaticSymbolsFeed, latestLinkShortUrlPrefix, azureDevOpsFeedsKey)
+            : base(isInternalBuild, isStableBuild, repositoryName, commitSha, null, publishInstallersAndChecksums, null, null, null, null, null, null, null, latestLinkShortUrlPrefix, null)


Can you refactor this to use named arguments? The number of arguments and number of nulls makes a silly mistake easy. Note that there is an quick-refactor for this in VS.

yep, will do

mmitche · 2021-09-28T16:20:12Z

+        private static string ConvertFromBase64(string value)
        {
-            if (string.IsNullOrEmpty(InstallersAzureAccountKey))
+            if (value == null)


Why the use of == null vs. IsNullOrEmpty?

(and if it's some subtle difference in behavior, it's worth a comment)

No real reason, I will change it.

mmitche · 2021-09-28T16:30:00Z

-                    flatten: Flatten));
+                foreach (var type in spec.ContentTypes)
+                {
+                    if (!PublishInstallersAndChecksums)


PublishInstallersAndChecksums should be assumed to be always true now

mmitche · 2021-09-28T16:36:22Z

+                        : (sasUri != null ? FeedType.AzureStorageContainer : FeedType.AzureStorageFeed);
+                    yield return new TargetFeedConfig(
+                        type,
+                        sasUri ?? feed,


I think this might be wrong? Second parameter is the target url, which makes sense for feed but not for sasUri, which I assume is just the suffix.

sasUri is the entire uri with sas token.

mmitche · 2021-09-28T16:38:49Z

-                String.Equals(InstallersFeed, config.InstallersFeed, StringComparison.OrdinalIgnoreCase) &&
+                string.Equals(AkaMSChannelName, config.AkaMSChannelName, StringComparison.OrdinalIgnoreCase) &&
+                TargetFeeds.Count == config.TargetFeeds.Count &&
+                TargetFeeds.Zip(config.TargetFeeds, (l, r) => l.Equals(r)).All(b => b) &&


That's cool, I didn't know about this method.

its even easier if this didn't have to work on net472, There is a nicer overload of Zip on newer frameworks.

mmitche

Approved with a few nits. Love the refactor. Before checking in, I would verify the following:

That checking in won't immediately break publishing - This shouldn't happen because there aren't changes that are outside of the arcade SDK and associated packages (like templates), but I would take this branch and attempt to run a simple promotion against it. Publishing behavior should not change.
Do tests (if you haven't already) against a branch of arcade that has its arcade updated to an official build of this branch.

@epananth Is the expert on testing publishing and can also help out if you have questions.

alexperovich · 2021-09-28T21:57:23Z

My latest test publishing run is here https://dev.azure.com/dnceng/internal/_build/results?buildId=1385970&view=logs&j=ba23343f-f710-5af9-782d-5bd26b102304&t=6e277ba4-1c1e-552d-b96f-db0aeb4be20a

Which tests are you refering to? The xunit ones?

mmitche · 2021-09-28T22:55:29Z

My latest test publishing run is here https://dev.azure.com/dnceng/internal/_build/results?buildId=1385970&view=logs&j=ba23343f-f710-5af9-782d-5bd26b102304&t=6e277ba4-1c1e-552d-b96f-db0aeb4be20a

Which tests are you refering to? The xunit ones?

That kind of test.

alexperovich · 2021-09-29T20:57:07Z

Those tests have all been run successfully.

michellemcdaniel

This passed in the test staging pipeline, so I'm happy

ghost · 2021-10-05T15:55:13Z

It looks like this breaks Arcade-validation's official build when it's trying to validate that using the newer Arcade SDK would not break publishing.

https://dev.azure.com/dnceng/internal/_build/results?buildId=1402340&view=results which tried to run this promotion pipeline run: https://dev.azure.com/dnceng/internal/_build/results?buildId=1403439&view=results is failing with a 403. Is there something that the repo needs to pipe through?

D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error : Service request failed.
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error : Status: 403 (Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.)
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error : ErrorCode: AuthenticationFailed
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error : 
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error : Headers:
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error : Transfer-Encoding: chunked
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error : Server: Microsoft-HTTPAPI/2.0
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error : x-ms-request-id: 7168d552-b01e-006e-7200-ba7748000000
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error : x-ms-error-code: AuthenticationFailed
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error : Date: Tue, 05 Oct 2021 15:51:48 GMT
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error : 
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error :    at Azure.Storage.Blobs.BlobRestClient.Blob.GetPropertiesAsync_CreateResponse(ClientDiagnostics clientDiagnostics, Response response)
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error :    at Azure.Storage.Blobs.BlobRestClient.Blob.GetPropertiesAsync(ClientDiagnostics clientDiagnostics, HttpPipeline pipeline, Uri resourceUri, String version, String snapshot, Nullable`1 timeout, String leaseId, String encryptionKey, String encryptionKeySha256, Nullable`1 encryptionAlgorithm, Nullable`1 ifModifiedSince, Nullable`1 ifUnmodifiedSince, Nullable`1 ifMatch, Nullable`1 ifNoneMatch, String requestId, Boolean async, String operationName, CancellationToken cancellationToken)
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error :    at Azure.Storage.Blobs.Specialized.BlobBaseClient.ExistsInternal(Boolean async, CancellationToken cancellationToken)
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error :    at Azure.Storage.Blobs.Specialized.BlobBaseClient.ExistsAsync(CancellationToken cancellationToken)
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error :    at Microsoft.DotNet.Build.Tasks.Feed.AzureStorageAssetPublisher.PublishAssetAsync(String file, String blobPath, PushOptions options, SemaphoreSlim clientThrottle) in /_/src/Microsoft.DotNet.Build.Tasks.Feed/src/AzureStorageAssetPublisher.cs:line 31
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error :    at Microsoft.DotNet.Build.Tasks.Feed.PublishArtifactsInManifestBase.<>c__DisplayClass171_0.<<PublishAssetsUsingStreamingPublishingAsync>b__0>d.MoveNext() in /_/src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs:line 1738
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error : --- End of stack trace from previous location ---
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error :    at Microsoft.DotNet.Build.Tasks.Feed.PublishArtifactsInManifestBase.PublishAssetsUsingStreamingPublishingAsync(IAssetPublisher assetPublisher, HashSet`1 assetsToPublish, Dictionary`2 buildAssets, TargetFeedConfig feedConfig, SemaphoreSlim clientThrottle) in /_/src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs:line 1702
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error :    at Microsoft.DotNet.Build.Tasks.Feed.PublishArtifactsInManifestBase.PublishAssetsAsync(IAssetPublisher assetPublisher, HashSet`1 assetsToPublish, Dictionary`2 buildAssets, TargetFeedConfig feedConfig, SemaphoreSlim clientThrottle) in /_/src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs:line 1644
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error :    at Microsoft.DotNet.Build.Tasks.Feed.PublishArtifactsInManifestBase.HandleBlobPublishingAsync(Dictionary`2 buildAssets, SemaphoreSlim clientThrottle) in /_/src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs:line 1025
D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error :    at Microsoft.DotNet.Build.Tasks.Feed.PublishArtifactsInManifestV3.ExecuteAsync() in /_/src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestV3.cs:line 186
##[error].packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.21504.5\tools\SdkTasks\PublishArtifactsInManifest.proj(139,5): error : Service request failed.
Status: 403 (Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.)
ErrorCode: AuthenticationFailed

epananth · 2021-10-05T18:14:35Z

I also saw this error yesterday when I was trying to promote runtime build -> https://dev.azure.com/dnceng/internal/_build/results?buildId=1402675&view=results

Add publishing to the dotnetbuilds storage account alongside dotnetcli

bf41bf0

alexperovich requested review from ChadNedzlek, MattGal, epananth, michellemcdaniel and mmitche September 10, 2021 00:00

alexperovich self-assigned this Sep 10, 2021

ChadNedzlek reviewed Sep 10, 2021

View reviewed changes

Comment thread src/Microsoft.DotNet.Build.Tasks.Feed/src/AssetPublisher.cs Outdated

ChadNedzlek reviewed Sep 10, 2021

View reviewed changes

Comment thread src/Microsoft.DotNet.Build.Tasks.Feed/src/AssetPublisherFactory.cs Outdated

ChadNedzlek reviewed Sep 10, 2021

View reviewed changes

Comment thread src/Microsoft.DotNet.Build.Tasks.Feed/src/AzureStorageExtensions.cs

ChadNedzlek reviewed Sep 10, 2021

View reviewed changes

Comment thread src/Microsoft.DotNet.Build.Tasks.Feed/src/SemaphoreLock.cs

ChadNedzlek approved these changes Sep 10, 2021

View reviewed changes

PR feedback

6ba4be3

mmitche reviewed Sep 13, 2021

View reviewed changes

michellemcdaniel reviewed Sep 13, 2021

View reviewed changes

Comment thread src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishArtifactsInManifest.proj

mmitche reviewed Sep 13, 2021

View reviewed changes

alexperovich added 2 commits September 13, 2021 15:44

More PR feedback

1dfe763

Merge branch 'main' into publishToDotNetBuilds

7fa8f1b

mmitche reviewed Sep 14, 2021

View reviewed changes

alexperovich added 2 commits September 24, 2021 16:19

Refactor Channel Configs based on feedback

d073ef7

Put the base64 back in the right place

060c3d2

mmitche reviewed Sep 28, 2021

View reviewed changes

mmitche approved these changes Sep 28, 2021

View reviewed changes

michellemcdaniel reviewed Oct 1, 2021

View reviewed changes

Comment thread src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishArtifactsInManifest.proj

michellemcdaniel approved these changes Oct 4, 2021

View reviewed changes

alexperovich merged commit 9902215 into dotnet:main Oct 4, 2021

alexperovich deleted the publishToDotNetBuilds branch October 4, 2021 21:16

danmoseley mentioned this pull request Feb 7, 2022

Add RuntimeConfiguration.NotRelease danmoseley/arcade#1

Closed

1 task

	public static TimeSpan NugetFeedPublisherHttpClientTimeout => TimeSpan.FromSeconds(300);
	public readonly static TimeSpan NugetFeedPublisherHttpClientTimeout = TimeSpan.FromSeconds(300);

Uh oh!

Conversation

alexperovich commented Sep 10, 2021

To double check:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

michellemcdaniel commented Sep 10, 2021

Uh oh!

mmitche commented Sep 10, 2021

Uh oh!

michellemcdaniel commented Sep 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexperovich commented Sep 13, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

michellemcdaniel commented Sep 13, 2021 •

edited

Loading