Skip to content

Fixup internal runtime support for source build#7711

Merged
mmitche merged 2 commits into
dotnet:mainfrom
mmitche:fix-source-build-template
Aug 5, 2021
Merged

Fixup internal runtime support for source build#7711
mmitche merged 2 commits into
dotnet:mainfrom
mmitche:fix-source-build-template

Conversation

@mmitche

@mmitche mmitche commented Aug 4, 2021

Copy link
Copy Markdown
Member
  • Add internal runtime download arguments as msbuild parameters, replacing the script parameters
  • Add internal nuget feed support
  • Modify the source build command to save the WIP changes in the test repo, which will cover changes to the NuGet.config file
  • Set up the user name and email if not set to support WIP changes.

To double check:

- Add internal runtime download arguments as msbuild parameters, replacing the script parameters
- Add internal nuget feed support
- Modify the source build command to save the WIP changes in the test repo, which will cover changes to the NuGet.config file
- Set up the user name and email if not set to support WIP changes.
@mmitche
mmitche requested a review from MichaelSimons August 4, 2021 18:28
@mmitche

mmitche commented Aug 4, 2021

Copy link
Copy Markdown
Member Author

This is necessary for aspnetcore to succeed (due to the way it does its initial tasks build)
@mmitche

mmitche commented Aug 5, 2021

Copy link
Copy Markdown
Member Author

This is g2g

@mmitche
mmitche merged commit a14c239 into dotnet:main Aug 5, 2021
@mmitche
mmitche deleted the fix-source-build-template branch February 9, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants