Setting maxClients for parallelism in yaml#7481
Conversation
| /// </summary> | ||
| public bool UseStreamingPublishing { get; set; } = false; | ||
|
|
||
| public int StreamingPublishingMaxClients {get; set;} |
There was a problem hiding this comment.
perhaps a short comment describing why these values are settable is in order.
There was a problem hiding this comment.
added a comment with the streaming and non streaming values
There was a problem hiding this comment.
The comments should be /// < Summary > style and go here
(argh github formatting)
| pool: | ||
| name: NetCoreInternal-Pool | ||
| queue: BuildPool.Server.Amd64.VS2019 | ||
| vmImage: 'windows-2019' |
There was a problem hiding this comment.
Unless I'm mistaken (please correct me if so), these values as set below won't do anything until:
- This change goes in to main
- The Arcade build containing these changes is promoted to use
- An Arcade -> Arcade dependency flow occurs and updates https://github.com/dotnet/arcade/blob/main/eng/Versions.props#L68 to the version of Tasks.Feed containing this change
As such, I think we should hold off using hosted machines until we can actually lower the numbers from default.
There was a problem hiding this comment.
Yes, I changed it back to NetCoreInternal-Pool and kept the numbers as 16 and 12 for now. I am good with changing the numbers after we hit any error
MattGal
left a comment
MattGal
left a comment
There was a problem hiding this comment.
Seems OK as-is, I'd suggest making the comments look a little different but NBD.
|
Hello @epananth! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
2 participants
To double check:
Issue -> https://github.com/dotnet/core-eng/issues/13098
Test -> https://dev.azure.com/dnceng/internal/_build/results?buildId=1175942&view=results