Specify LastExit scope#7465
Merged
Merged
Conversation
Member
|
There are a few more instances of this pattern: arcade/eng/common/sdl/init-sdl.ps1 Line 13 in be9124c |
jonfortescue
approved these changes
Jun 3, 2021
jonfortescue
left a comment
jonfortescue
left a comment
Contributor
There was a problem hiding this comment.
I'd look at the stuff Davis mentioned but otherwise this seems good.
Member
Author
Good catch, thank you. |
dagood
approved these changes
Jun 4, 2021
dagood
left a comment
dagood
left a comment
Member
There was a problem hiding this comment.
LGTM. I think it'd be good to update this too, for the future: https://github.com/dotnet/arcade/blob/main/Documentation/Policy/PowershellBestPractices.md
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify global scope in prepping LastExit to avoid shadowing.
I confirmed the scope-change behavior work as expected locally, and verified that this change did not cause any SDL failures in SDK, runtime or aspnetcore repositories.