Retry for InitializeXCopyMSBuild#7464
Merged
lukas-lansky merged 3 commits intoJun 9, 2021
Merged
Conversation
|
I don't think we have a resusable retry anywhere in the scripts. Extracting the retry functionality for at least all the retries in this file would be nice. |
Contributor
Author
|
I verified the change by applying it locally to runtime repo and building it. Adding Lukasz as he is a PowerShell expert. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm hitting the Rule of Three. Before I refactor the retries into some common function, do you happen to know if we have already something like that can could be referenced here @riarenas ?
https://github.com/dotnet/core-eng/issues/13188