Use msbuild logging for symbol messages#7352
Merged
Merged
Conversation
Because the symbol upload internally uses the msbuild loggers, if this code uses a string builder and then prints all the info at the end, the binlog tends to look like: symbol upload diagnostic for symbol package 1 symbol upload diagnostic for symbol package 1 symbol upload diagnostic for symbol package 2 symbol upload diagnostic for symbol package 2 symbol upload diagnostic for symbol package 3 symbol upload diagnostic for symbol package 3 ... top level upload info for 1 top level upload info for 2 top level upload info for 3 Instead, it's easier to read as: top level upload info for 1 symbol upload diagnostic for symbol package 1 symbol upload diagnostic for symbol package 1 top level upload info for 2 symbol upload diagnostic for symbol package 2 symbol upload diagnostic for symbol package 2 top level upload info for 3 symbol upload diagnostic for symbol package 3 symbol upload diagnostic for symbol package 3 There will be some interleaving due to parallelism, but right now it's difficult to line up the top level messages with the diagnostic ones.
Member
Author
|
@epananth I can wait till your stuff goes in to avoid merge conflicts. |
Member
|
Yes, Still building. Will merge it soon and let you know.. |
Member
|
I merged my changes. |
epananth
approved these changes
May 12, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the symbol upload internally uses the msbuild loggers, if this code uses a string builder and then prints all the info at the end, the binlog tends to look like:
Instead, it's easier to read as:
There will be some interleaving due to parallelism, but right now it's difficult to line up the top level messages with the diagnostic ones.
To double check: