Skip to content

Adding in cross dependencies for ML.NET#7338

Merged
ericstj merged 1 commit into
dotnet:mainfrom
michaelgsharp:ml-net
May 4, 2021
Merged

Adding in cross dependencies for ML.NET#7338
ericstj merged 1 commit into
dotnet:mainfrom
michaelgsharp:ml-net

Conversation

@michaelgsharp

Copy link
Copy Markdown
Contributor

ML.NET is working on adding cross-platform support. Enabling cross-targeting for linux will help with that, so this PR adds the needed dependences to use the code that is already present in Arcade.

@ericstj
ericstj merged commit 3d7a9cd into dotnet:main May 4, 2021
@janvorli

janvorli commented Jul 9, 2021

Copy link
Copy Markdown
Member

@michaelgsharp why do we need the libomp5? Isn't the libomp-dev sufficient? The rootfs should only need build time libraries. I am asking since the presence of libomp5 breaks rootfs build for s390x (there is no such package for that arch) and so it breaks the dotnet/dotnet-buildtools-prereqs-docker repo that creates image for that architecture too.

@michaelgsharp

Copy link
Copy Markdown
Contributor Author

@janvorli so for running the code we need libomp5, but we aren't running the code here, just compiling. I think we are safe to remove libomp5. I put it there because those were the packages we use that weren't listed here, though I didn't test it without that package.

If its causing problems I would go ahead and remove it because I think we are good without it. If worst comes to worst I can always have a step that installs it before we run our build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants