Skip the remote executor tests#7321
Merged
Merged
Conversation
alexperovich
requested review from
a user,
ChadNedzlek,
MattGal and
jakubstilec
April 29, 2021 20:33
ChadNedzlek
approved these changes
Apr 29, 2021
MattGal
reviewed
Apr 29, 2021
| public class RemoteExecutorTests | ||
| { | ||
| [Fact] | ||
| [Fact(Skip = "Remote executor is broken in VS test explorer")] |
Member
There was a problem hiding this comment.
How does this not disable it from normal console execution?
Contributor
There was a problem hiding this comment.
Is that even possible?
Member
Author
There was a problem hiding this comment.
its only possible by basically rewriting swaths of xunit to make a custom Fact attribute.
Member
There was a problem hiding this comment.
I thought runtime did this all the time using some kind of extension pattern. Just seems like perma-skip = never run and I understand they pass outside of VS.
Contributor
There was a problem hiding this comment.
Runtime has a huge swath of custom fact stuff that I don't think we want to duplicate just to deal with these handful of tests. :-)
jakubstilec
approved these changes
May 3, 2021
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7092