Skip to content

Run signcheck in single threaded apartment#7241

Merged
chcosta merged 1 commit into
dotnet:mainfrom
chcosta:fix-signtooltask
Apr 15, 2021
Merged

Run signcheck in single threaded apartment#7241
chcosta merged 1 commit into
dotnet:mainfrom
chcosta:fix-signtooltask

Conversation

@chcosta

@chcosta chcosta commented Apr 14, 2021

Copy link
Copy Markdown
Member

Fixes #7238

Remove WTD_SAFER_FLAG which is no longer supported - see https://docs.microsoft.com/en-us/windows/win32/api/wintrust/ns-wintrust-wintrust_data

Load task in separate app domain

Use Single Threaded Apartment

@michellemcdaniel michellemcdaniel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

@chcosta
chcosta merged commit 40ecdb3 into dotnet:main Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SignCheck failing to validated javascript files are signed

4 participants