Fix | Write DateOnly instances to sql_variant columns of table-valued parameters as date values by edwardneal · Pull Request #4439 · dotnet/SqlClient

edwardneal · 2026-07-11T19:00:03Z

Description

This builds on #4294, and handles the only other issue I saw while investigating #3934.

If a user-defined table type exists with a column of type sql_variant, client applications can insert a DateOnly instance into this. It's supposed to be sent with a type of date, but is actually sent as a datetime.

Besides a point around correctness, it presents an issue when sending DateOnly instances which are valid values for date but not for datetime: these values overflow.

This PR fixes the issue, transporting all DateOnly instances with the date type on modern .NET. On .NET Framework, there's no DateOnly type - and thus there's no way for the client to encapsulate a date value within a sql_variant column.

@ErikEJ, this covers the only other way to write DateOnly instances to SQL Server and should hopefully completely close #3934. SqlClient will continue to read DateTime instances by default, but this is needed for backwards compatibility purposes.

NB: similar issues also exist with TimeOnly instances. TdsParser assumes that only TimeSpan instances will be written as times, so there are failures to cast in a few different places.

Issues

Builds on #4294. Possible resolution to #3934.

Testing

#4294 added the relevant tests, with an exemption carved out for this use case. I've removed the exemption and verified that it covers the test case.

Instances of DateOnly stored within a SqlDataRecord field of type Variant will now be sent as dates, not datetimes. By extension: sending DateOnly instances with values outside the acceptable range for a datetime will no longer throw overflow exceptions.

azure-pipelines · 2026-07-11T19:00:14Z

Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run.

ErikEJ

LGTM

cheenamalhotra · 2026-07-20T20:57:38Z

/azp run

azure-pipelines · 2026-07-20T20:58:08Z

Azure Pipelines: Successfully started running 3 pipeline(s).

codecov · 2026-07-20T23:05:57Z

Codecov Report

❌ Patch coverage is 11.11111% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.64%. Comparing base (fdebcd2) to head (226969c).
⚠️ Report is 66 commits behind head on main.

Files with missing lines	Patch %	Lines
...c/Microsoft/Data/SqlClient/Server/ValueUtilsSmi.cs	9.09%	20 Missing ⚠️
...c/Microsoft/Data/SqlClient/Server/SqlDataRecord.cs	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4439      +/-   ##
==========================================
- Coverage   65.83%   62.64%   -3.20%     
==========================================
  Files         287      283       -4     
  Lines       43763    66949   +23186     
==========================================
+ Hits        28812    41938   +13126     
- Misses      14951    25011   +10060

Flag	Coverage Δ
CI-SqlClient	`?`
PR-SqlClient-Project	`62.64% <11.11%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

benrr101

Small change but seems pretty important!

Copilot

Pull request overview

This PR addresses a correctness issue when sending DateOnly values into sql_variant columns in table-valued parameters (TVPs): the value was being transported as datetime rather than date, which can overflow for DateOnly min/max values and yields an incorrect base type.

Changes:

Updates TVP/SMI value-setting logic so DateOnly written to sql_variant is transported with base type date (modern .NET only).
Relaxes variant metadata assertions to allow SqlDbType.Date where variant-type metadata is tracked.
Updates manual variant tests to remove the prior overflow/“datetime” exemptions now that the scenario should succeed.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/DateTimeVariantTests.cs	Removes expected overflow exceptions / base-type overrides for `DateOnly` in `sql_variant` TVP scenarios.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/ValueUtilsSmi.cs	Routes `DateOnly` through date-specific variant metadata handling for TVP writes; also adjusts sql-value retrieval logic for `SqlDbType.Date`.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/SqlRecordBuffer.cs	Allows `SqlDbType.Date` in the debug assertion for variant metadata.

Ensure that SqlDataRecord.GetSqlValue doesn't return a DateOnly instance. Apply the same pattern as SqlDataReader - directly expose the original variant type metadata, and base the decision on that.

apoorvdeshmukh · 2026-07-27T18:57:44Z

/azp run

azure-pipelines · 2026-07-27T18:59:35Z

Azure Pipelines: Successfully started running 3 pipeline(s).

Both are user-facing fixes merged into the preview3 milestone that were not yet captured in the release notes or CHANGELOG: - #4439: DateOnly values in sql_variant TVP columns were sent as datetime instead of date, overflowing for values outside the datetime range. - #4445: ServerCertificate pin validation was skipped when the platform reported no TLS policy errors, and an unloadable certificate file fell back to host-name validation instead of failing closed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8c691319-4c66-40f6-a88e-b453937052f1

* Add release notes for 7.1.0-preview3 Adds release notes for Microsoft.Data.SqlClient 7.1.0-preview3 and its four aligned companion packages, updates the per-version README index tables, and adds the corresponding CHANGELOG entry. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c7425f3e-f6b8-439b-b74f-e25f8406fbf6 * Capture remaining closed 7.1.0-preview3 milestone items in release notes Adds coverage for milestone items that closed after the initial draft: - #4529 leaked-connection reclamation in ChannelDbConnectionPool - #4535 SqlBulkCopy graph column alias mapping bypass - #4521 / #4496 Entra ID tenant parsing for multi-segment STSURL authorities - #4540 async key store provider APIs in the AzureKeyVaultProvider Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c485150e-f46e-4c55-8d06-e0491a10e7e8 * Add #4439 and #4445 to 7.1.0-preview3 release notes Both are user-facing fixes merged into the preview3 milestone that were not yet captured in the release notes or CHANGELOG: - #4439: DateOnly values in sql_variant TVP columns were sent as datetime instead of date, overflowing for values outside the datetime range. - #4445: ServerCertificate pin validation was skipped when the platform reported no TLS policy errors, and an unloadable certificate file fell back to host-name validation instead of failing closed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8c691319-4c66-40f6-a88e-b453937052f1 * Add #4474 to 7.1.0-preview3 cross-platform build notes PR #4474 (Remove OS-Specific Builds) removed OS-specific build targets and output paths, and rewrote the MDS nuspec to source a single OS-agnostic assembly for both the win and unix runtime folders. Verified the nuspec change is src-path-only: all 52 file entries have identical target= values before and after, so the produced package layout is unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8c691319-4c66-40f6-a88e-b453937052f1 * Clarify #4536 allocation fix applies to the default async read path Addresses review feedback on PR #4565: the PacketData node-reuse fix is not gated behind UseCompatibilityAsyncBehaviour or any other AppContext switch, and the perf validation was measured on the default path. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8c691319-4c66-40f6-a88e-b453937052f1 * Scope preview3 release notes to customer-facing changes Remove entries with no customer-visible effect, and reframe entries that led with implementation detail rather than customer impact. Removed: - #3862 ConnectionCapabilities consolidation - internal refactor; the GetSchema("DataTypes") fix it enables is deferred to a later PR. - #3700/#3741 SSRP scaffolding - adds no parsing code and no behavior change. - #4517 CodeQL findings - PKCS#1 half is suppression comments for declared false positives; the SHA-1 removal is a no-op in practice. - #4421 Extensions.Azure APIScan remediation - no public API change and managed-identity behavior preserved exactly; the removed assignment was already a no-op. Extensions.Azure now has no Changed section. Promoted: - #4504 counter fixes moved from a pool V2 sub-bullet into Fixed. These affect the default pool that customers use without opting in, and the previous text understated them as two fixes limited to Count. Reframed: - Cross-platform build collapsed to the one customer-visible outcome (trimming on Linux/macOS); package contents were always unchanged. - #4528 now leads with the allocation regression rather than call-site count. - AKV cache fixes now lead with symptoms (unbounded signature cache growth, duplicate CryptographyClient per key) rather than GetOrCreate/GetOrAdd. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8c691319-4c66-40f6-a88e-b453937052f1 --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c7425f3e-f6b8-439b-b74f-e25f8406fbf6 Copilot-Session: c485150e-f46e-4c55-8d06-e0491a10e7e8 Copilot-Session: 8c691319-4c66-40f6-a88e-b453937052f1

edwardneal requested a review from a team as a code owner July 11, 2026 19:00

github-project-automation Bot added this to SqlClient Board Jul 11, 2026

github-project-automation Bot moved this to To triage in SqlClient Board Jul 11, 2026

ErikEJ reviewed Jul 13, 2026

View reviewed changes

paulmedynski moved this from To triage to Backlog in SqlClient Board Jul 16, 2026

cheenamalhotra added this to the 7.1.0-preview3 milestone Jul 20, 2026

cheenamalhotra moved this from Backlog to In review in SqlClient Board Jul 20, 2026

cheenamalhotra assigned benrr101 and apoorvdeshmukh Jul 20, 2026

benrr101 previously approved these changes Jul 22, 2026

View reviewed changes

Comment thread src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/SqlRecordBuffer.cs Outdated

apoorvdeshmukh requested a review from Copilot July 23, 2026 14:32

Copilot started reviewing on behalf of apoorvdeshmukh July 23, 2026 14:32 View session

Copilot AI reviewed Jul 23, 2026

View reviewed changes

Comment thread src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/ValueUtilsSmi.cs

edwardneal added 2 commits July 23, 2026 20:13

Code review

9e9c57f

Ensure that SqlDataRecord.GetSqlValue doesn't return a DateOnly instance. Apply the same pattern as SqlDataReader - directly expose the original variant type metadata, and base the decision on that.

Code review - style nit

226969c

edwardneal dismissed benrr101’s stale review via 226969c July 23, 2026 19:41

benrr101 approved these changes Aug 14, 2026

View reviewed changes

priyankatiwari08 approved these changes Aug 24, 2026

View reviewed changes

priyankatiwari08 merged commit 7054399 into dotnet:main Aug 24, 2026
358 checks passed

github-project-automation Bot moved this from In review to Done in SqlClient Board Aug 24, 2026

cheenamalhotra mentioned this pull request Aug 25, 2026

Tests | Fix TVP query hint test timeouts against shared Azure SQL DB #4593

Merged

4 tasks

edwardneal deleted the fix/dateonly-tvp-variant branch August 25, 2026 19:13

edwardneal mentioned this pull request Aug 26, 2026

Feature | Write TimeOnly instances as time values #4604

Open

dependabot Bot mentioned this pull request Sep 1, 2026

deps: Bump Microsoft.Data.SqlClient from 7.1.0-preview2.26190.5 to 7.1.0-preview3.26238.4 Taiizor/Zetian#73

Open

Navigation Menu

Uh oh!

Fix | Write DateOnly instances to sql_variant columns of table-valued parameters as date values - #4439

Fix | Write DateOnly instances to sql_variant columns of table-valued parameters as date values#4439
priyankatiwari08 merged 3 commits into
dotnet:mainfrom
edwardneal:fix/dateonly-tvp-variant

edwardneal commented Jul 11, 2026

Uh oh!

azure-pipelines Bot commented Jul 11, 2026

Uh oh!

ErikEJ left a comment

Uh oh!

cheenamalhotra commented Jul 20, 2026

Uh oh!

azure-pipelines Bot commented Jul 20, 2026

Uh oh!

codecov Bot commented Jul 20, 2026 •

edited

Loading

Uh oh!

benrr101 left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

apoorvdeshmukh commented Jul 27, 2026

Uh oh!

azure-pipelines Bot commented Jul 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

edwardneal commented Jul 11, 2026

Description

Issues

Testing

Uh oh!

azure-pipelines Bot commented Jul 11, 2026

Uh oh!

ErikEJ left a comment

Choose a reason for hiding this comment

Uh oh!

cheenamalhotra commented Jul 20, 2026

Uh oh!

azure-pipelines Bot commented Jul 20, 2026

Uh oh!

codecov Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

benrr101 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

apoorvdeshmukh commented Jul 27, 2026

Uh oh!

azure-pipelines Bot commented Jul 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecov Bot commented Jul 20, 2026 •

edited

Loading