Fix ImageBuild Auth, message stream - repacked#507
Merged
Conversation
# Conflicts: # src/Docker.DotNet/Endpoints/IImageOperations.cs
…ld BuildImageFromDockerfileAsync and obsolete it to not break anyone if this gets merged. Fix comments.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All credit to @jhenkens for this. The old PR looks to be abandoned so wanted to make a new attempt. Minor changes to the original PR with notes in the commits.
Original message:
Fixes #445 and #417
Properly parses the response from ImageBuild as a progress stream, and properly initializes and passes the AuthConfigs via header. Confirmed working with local usage.