Skip to content

fix: Fix OsDetector logics on windows#3193

Merged
timcassell merged 1 commit into
dotnet:masterfrom
filzrev:fix-osdetector-logics
Jul 9, 2026
Merged

fix: Fix OsDetector logics on windows#3193
timcassell merged 1 commit into
dotnet:masterfrom
filzrev:fix-osdetector-logics

Conversation

@filzrev

@filzrev filzrev commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

This PR intended to fix issue that commented on https://github.com/dotnet/BenchmarkDotNet/pull/3190/changes#r3526354668 issue.

By this PR changes,
OS name is displayed same as previous build on Windows (OS display name is formatted by Perfolizer at

if (vmName.IsNotBlank())
yield return $"{BenchmarkDotNetCaption} v{BenchmarkDotNetVersion}, {Os.Value.ToBrandString()} ({vmName})";
else if (RuntimeInformation.IsRunningInContainer)
yield return $"{BenchmarkDotNetCaption} v{BenchmarkDotNetVersion}, {Os.Value.ToBrandString()} (container)";
else
yield return $"{BenchmarkDotNetCaption} v{BenchmarkDotNetVersion}, {Os.Value.ToBrandString()}";
)

On current master branch result

BenchmarkDotNet v0.16.0-develop (2026-07-09), Microsoft Windows 10.0.26200 Microsoft Windows NT 10.0.26200.0.8737

On this PR branch result

BenchmarkDotNet v0.16.0-develop (2026-07-09), Windows 11 (10.0.26200.8737/25H2/2025Update/HudsonValley2)

@timcassell timcassell merged commit f3ac0c1 into dotnet:master Jul 9, 2026
11 checks passed
@timcassell timcassell added this to the v0.16.0 milestone Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants