Fix that XML comment examples do not show up if the type is string and the example contains quotation marks - #2727
Merged
martincostello merged 6 commits intoMay 6, 2024
Conversation
dldl-cmd
force-pushed
the
2088_fix_string_examples_with_quotes
branch
from
October 13, 2023 19:45
618102c to
96ae699
Compare
bbarry
reviewed
Oct 17, 2023
Collaborator
|
Thanks for contributing - if you'd like to continue with this pull request, please rebase against the default branch to pick up our new CI. |
|
@dldl-cmd Does this happen to fix general issues with example parsing, such as backslashes in the string leading to the example being omitted completely? |
dldl-cmd
force-pushed
the
2088_fix_string_examples_with_quotes
branch
from
April 15, 2024 18:34
33ae493 to
3ca86f8
Compare
|
@martincostello It looks like the expected CI builds didn't run here - they're awaiting approval. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2727 +/- ##
==========================================
- Coverage 92.40% 92.39% -0.02%
==========================================
Files 93 94 +1
Lines 3174 3167 -7
Branches 558 555 -3
==========================================
- Hits 2933 2926 -7
Misses 241 241
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…d the example contains quotation marks
- use static string.Equals - assert for not null and correct type
dldl-cmd
force-pushed
the
2088_fix_string_examples_with_quotes
branch
from
May 5, 2024 14:49
dbaecbc to
7989435
Compare
|
Is this something that mind find its way into v6.6 by any chance? |
martincostello
approved these changes
May 6, 2024
1 task
This was referenced Aug 4, 2025
This was referenced Jul 29, 2026
Open
Open
Open
Bump Swashbuckle.AspNetCore from 5.6.3 to 10.2.3
felipeswat/skills-secure-repository-supply-chain#12
Open
Open
Bump Swashbuckle.AspNetCore from 5.6.3 to 10.2.3
ctn4kn59mh/skills-secure-repository-supply-chain#12
Open
Open
Open
Open
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix that XML comment examples do not show up if the type is string and the example contains quotation marks
Resolves #2088