Skip to content

fixed absolute links#883

Merged
johndmulhausen merged 2 commits into
docker:masterfrom
aduermael:fix-absolute-links
Dec 14, 2016
Merged

fixed absolute links#883
johndmulhausen merged 2 commits into
docker:masterfrom
aduermael:fix-absolute-links

Conversation

@aduermael

Copy link
Copy Markdown
Contributor

Proposed changes

Fixed absolute links in current version's content for new tests in #849 to pass.

Signed-off-by: Adrien Duermael <adrien@duermael.com>
Signed-off-by: Adrien Duermael <adrien@duermael.com>
@sanscontext

Copy link
Copy Markdown
Contributor

Does this actually work without breaking these links in the Docker Cloud docs? I wasn't aware that HTML would allow relative links on target="_blank" anchors.

(For reference, I'm making a specific design decision in the Cloud docs to open a new tab so that the reader isn't distracted from a tutorial flow. This modifier isn't supported by markdown, which is why it's in HTML.)

@aduermael

Copy link
Copy Markdown
Contributor Author

@sanscontext

I wasn't aware that HTML would allow relative links on target="_blank" anchors.

I assume it works... Can you point me to a page that could bring that kind of issue?

@aduermael

Copy link
Copy Markdown
Contributor Author

@sanscontext
I just tried this link in /docker-cloud/builds/push-images/:
screen shot 2016-12-14 at 12 20 15 pm

It opens a new tab, even with a relative link.

@sanscontext

Copy link
Copy Markdown
Contributor

Sorry, I'd been waiting for the Netlify preview to show up - forgot it's now hidden three clicks deep. :P All my specific links appear to be working!

@aduermael

Copy link
Copy Markdown
Contributor Author

ping @johndmulhausen

@johndmulhausen

Copy link
Copy Markdown
Contributor

Thanks, @aduermael :)

@johndmulhausen johndmulhausen merged commit 94c80be into docker:master Dec 14, 2016
@johndmulhausen johndmulhausen self-assigned this Dec 14, 2016
@aduermael

Copy link
Copy Markdown
Contributor Author

thanks @johndmulhausen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants