Clarify Hyper-V and VirtualBox info for Docker for Windows#256
Merged
mdlinville merged 1 commit intoOct 20, 2016
Conversation
johndmulhausen
suggested changes
Oct 19, 2016
johndmulhausen
left a comment
johndmulhausen
left a comment
Contributor
There was a problem hiding this comment.
The asymmetry in the prescriptive text bugs me, but other than that this LGTM from a docs perspective. You aren't really changing the technical assertions, near as I can tell, so it may be that you can merge w/o technical feedback/
|
|
||
| - Docker for Mac: You can create additional `docker-machine` machines using the | ||
| `virtualbox` driver. | ||
| - Docker for Windows: You can create additional `docker-machine` machines, but you |
Contributor
There was a problem hiding this comment.
I would simplify to:
Docker for Windows: You can create additional docker-machine machines using the hyperv driver.
|
thanks, its certainly helps to avoid 1 misinterpretation 😄 |
Fixes #134 Signed-off-by: Misty Stanley-Jones <misty@docker.com>
This was referenced Oct 25, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the proposed changes
Reworded a couple spots to clarify the situation with Hyper-V and Virtualbox on Docker for Windows
Project version
n/a
Related issue
#134
Related issue or PR in another project
n/a
Please take a look
@londoncalling @engcheng