fix(#3996): preserve Gemini user thinking budgets outside title generation - #4028
Draft
aheritier wants to merge 1 commit into
Draft
fix(#3996): preserve Gemini user thinking budgets outside title generation#4028aheritier wants to merge 1 commit into
aheritier wants to merge 1 commit into
Conversation
aheritier
added
area/providers/gemini
aheritier
force-pushed
the
gemini-direct-image-output
branch
from
August 24, 2026 15:13
b4dbc21 to
84d8c20
Compare
aheritier
force-pushed
the
gemini-direct-image-output
branch
from
August 25, 2026 08:00
84d8c20 to
a89ad52
Compare
aheritier
force-pushed
the
gemini-direct-image-output
branch
from
August 25, 2026 08:17
a89ad52 to
1b7dc6c
Compare
aheritier
force-pushed
the
gemini-direct-image-output
branch
from
August 25, 2026 08:33
1b7dc6c to
9b1176c
Compare
aheritier
force-pushed
the
gemini-direct-image-output
branch
from
August 25, 2026 20:24
9b1176c to
53d7a5c
Compare
aheritier
force-pushed
the
gemini-direct-image-output
branch
from
August 26, 2026 11:10
53d7a5c to
c56cc55
Compare
aheritier
force-pushed
the
gemini-direct-image-output
branch
3 times, most recently
from
September 1, 2026 16:07
5339887 to
c56cc55
Compare
aheritier
force-pushed
the
gemini-direct-image-output
branch
from
September 1, 2026 16:30
c56cc55 to
2c8d6b1
Compare
aheritier
force-pushed
the
gemini-direct-image-output
branch
from
September 1, 2026 19:58
2c8d6b1 to
97877c1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
aheritier
force-pushed
the
gemini-direct-image-output
branch
from
September 6, 2026 16:15
97877c1 to
5f8df8a
Compare
aheritier
force-pushed
the
gemini-direct-image-output
branch
from
September 7, 2026 11:19
5f8df8a to
db6f22e
Compare
aheritier
force-pushed
the
gemini-direct-image-output
branch
2 times, most recently
from
September 7, 2026 16:13
74fb2a0 to
4a10093
Compare
aheritier
force-pushed
the
gemini-direct-image-output
branch
from
September 7, 2026 16:47
4a10093 to
2dde430
Compare
aheritier
force-pushed
the
gemini-direct-image-output
branch
from
September 8, 2026 06:17
2dde430 to
c421fde
Compare
Omit thinkingConfig for title-generation requests so image-capable Gemini models can return plain text titles. Increase the shared title output budget from 20 to 128 tokens to accommodate hidden reasoning while keeping the visible title separately capped at 50 characters. Preserve explicit no-thinking behavior for MCP sampling and ordinary requests, including Gemini 3 minimum reasoning settings and Gemini 2.5 zero-budget suppression. Keep user-configured thinking budgets outside title generation unchanged and test both paths.
aheritier
force-pushed
the
gemini-direct-image-output
branch
from
September 8, 2026 07:58
c421fde to
41bcf76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Preserves Gemini user thinking budgets for ordinary image-output requests while retaining the special title-generation behavior, with guard and integration tests.
Why
Image-output requests must honor the user's configured reasoning budget; only title generation should use its constrained policy.
Validation
task test; Gemini client, modality, guard, and runtime/TUI integration tests.Test instructions
Run:
task testIssue a Gemini image-output request with a non-default user thinking budget and inspect the outgoing request. Expected: the configured budget is preserved. Trigger session title generation separately; expected: its constrained title-generation policy remains unchanged.