Documenting example default-ulimit in daemon.json#1446
Merged
Conversation
Signed-off-by: Brandon Mitchell <git@bmitch.net>
Codecov Report
@@ Coverage Diff @@
## master #1446 +/- ##
======================================
Coverage 54.2% 54.2%
======================================
Files 289 289
Lines 19378 19378
======================================
Hits 10503 10503
Misses 8199 8199
Partials 676 676 |
cpuguy83
reviewed
Oct 17, 2018
| "cgroup-parent": "", | ||
| "default-ulimits": {}, | ||
| "default-ulimits": { | ||
| "nofile": { |
Collaborator
There was a problem hiding this comment.
Maybe we can pick a different one, just because nofile is per user and not per-container.... just basically don't want someone to take this as a recommendation of some sort.
Contributor
Author
There was a problem hiding this comment.
Isn't that just for nproc? I thought nofile was per process. If both are per user then we'll want to update some other docs to warn users. Might be good to have a table of each of the ulimit names and a brief description somewhere to avoid confusion.
Collaborator
There was a problem hiding this comment.
Ah you are right, it is nproc!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brandon Mitchell git@bmitch.net
- What I did
The documentation on setting a default-ulimit using the daemon.json file was missing an example. This includes an example syntax.
(Remaining PR sections removed since this is just a documentation change.)