Skip to content

feat: general component improvements - #5787

Merged
iCrawl merged 3 commits into
discordjs:masterfrom
monbrey:component-improvements
Jun 9, 2021
Merged

feat: general component improvements#5787
iCrawl merged 3 commits into
discordjs:masterfrom
monbrey:component-improvements

Conversation

@monbrey

@monbrey monbrey commented Jun 9, 2021

Copy link
Copy Markdown
Member

By request, this PR extract several of the general improvements I had discovered while working on #5692 into a separate PR.

  • Subclasses for MessageComponentInteraction per component type
  • Support for parsing arrays of components as rows in raw options
  • Improved raw emoji resolution in component builders
  • Typings fixes
  • Documentation improvements and consistency

Please move lines that apply to you out of the comment:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@iCrawl
iCrawl requested review from SpaceEEC, kyranet and vladfrangu June 9, 2021 08:16
@monbrey
monbrey marked this pull request as ready for review June 9, 2021 08:25
Comment thread src/structures/APIMessage.js Outdated
Comment thread src/util/Util.js Outdated
Comment thread typings/index.d.ts Outdated
Comment thread src/util/Util.js Outdated
@iCrawl

iCrawl commented Jun 9, 2021

Copy link
Copy Markdown
Member

This needs a rebase.

@monbrey
monbrey force-pushed the component-improvements branch from 7dea736 to 8821b3c Compare June 9, 2021 12:27
@kyranet
kyranet requested a review from SpaceEEC June 9, 2021 12:46
@iCrawl
iCrawl merged commit c4f1c75 into discordjs:master Jun 9, 2021
@monbrey
monbrey deleted the component-improvements branch June 9, 2021 18:05
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants