Warning with maven multi module projects for non-installed dependencies.

[pdeneve]

Given a maven multi module project for which a module depends an another module within the same multi module project and the other module has not been installed, the following warning is issued when doing mvn spotless apply or mvn spotless check (even without the expandWildcardImports option):

[WARNING] Could not resolve project dependencies for expandWildcardImports: Unable to resolve dependencies

To reproduce:

git clone https://github.com/pdeneve/spotless-expand-wildcard-imports-issue.git
cd spotless-expand-wildcard-imports-issue
git checkout warning
mvn spotless:apply

Spotless maven plugin version used = 3.5.1

[cslettengren-nn]

I also get that warning. In my repos the problem seems to be that dependencies with <type>test-jar</type> are resolved with extension test-jar instead of jar.

I think it might be a bug in ArtifactResolver.java

 .map(d -> new Dependency(
          new DefaultArtifact(d.getGroupId(), d.getArtifactId(), d.getClassifier(), d.getType(), d.getVersion()),
          d.getScope()))

should probably be

  .map(d -> {
      ArtifactType stereotype = session.getArtifactTypeRegistry().get(d.getType());
      return new Dependency(
              new DefaultArtifact(
                      d.getGroupId(),
                      d.getArtifactId(),
                      d.getClassifier(),
                      null,        // let the stereotype supply the extension
                      d.getVersion(),
                      stereotype),
              d.getScope());
  })