Skip to content

feat: New fallback logic for geometry in analytics [DHIS2-13528] - #11384

Merged
d-bernat merged 4 commits into
masterfrom
2.39-DHIS2-13528
Aug 3, 2022
Merged

feat: New fallback logic for geometry in analytics [DHIS2-13528]#11384
d-bernat merged 4 commits into
masterfrom
2.39-DHIS2-13528

Conversation

@d-bernat

@d-bernat d-bernat commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

@maikelarabori maikelarabori left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @d-bernat, just some minor comments/suggestions 👍

@maikelarabori maikelarabori changed the title 2.39 dhis2 13528 feat: New fallback logic for geometry in analytics [DHIS2-13528] Aug 3, 2022

@gnespolino gnespolino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left just a suggestion for a small possible refactoring, feel free to implement if you think it's good

@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov

codecov Bot commented Aug 3, 2022

Copy link
Copy Markdown

Codecov Report

Merging #11384 (3ecd27c) into master (eb93a57) will increase coverage by 0.09%.
The diff coverage is 59.37%.

@@             Coverage Diff              @@
##             master   #11384      +/-   ##
============================================
+ Coverage     63.15%   63.24%   +0.09%     
- Complexity    27252    27292      +40     
============================================
  Files          3195     3195              
  Lines        112650   112722      +72     
  Branches      13244    13249       +5     
============================================
+ Hits          71143    71292     +149     
+ Misses        35396    35320      -76     
+ Partials       6111     6110       -1     
Flag Coverage Δ
integration 45.57% <40.62%> (+0.10%) ⬆️
integration-h2 32.90% <40.62%> (-0.01%) ⬇️
unit 28.54% <15.62%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nalytics/event/data/JdbcEventAnalyticsManager.java 49.57% <0.00%> (-0.86%) ⬇️
...rg/hisp/dhis/analytics/event/EventQueryParams.java 73.29% <66.66%> (-0.10%) ⬇️
...ytics/event/data/DefaultEventDataQueryService.java 84.92% <77.77%> (-0.68%) ⬇️
.../hisp/dhis/common/FallbackCoordinateFieldType.java 100.00% <100.00%> (ø)
...n/java/org/hisp/dhis/attribute/AttributeValue.java 71.42% <0.00%> (-5.72%) ⬇️
...rc/main/java/org/hisp/dhis/common/QueryFilter.java 45.83% <0.00%> (-3.01%) ⬇️
...c/main/java/org/hisp/dhis/attribute/Attribute.java 95.47% <0.00%> (-1.01%) ⬇️
...rc/main/java/org/hisp/dhis/feedback/ErrorCode.java 100.00% <0.00%> (ø)
...objectbundle/validation/attribute/NumberCheck.java 100.00% <0.00%> (ø)
...alidation/attribute/DefaultAttributeValidator.java 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb93a57...3ecd27c. Read the comment docs.

@d-bernat
d-bernat merged commit f21412f into master Aug 3, 2022
@d-bernat
d-bernat deleted the 2.39-DHIS2-13528 branch August 3, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants