feat: New fallback logic for geometry in analytics [DHIS2-13528] - #11384
Merged
Conversation
maikelarabori
approved these changes
Aug 3, 2022
maikelarabori
left a comment
Contributor
There was a problem hiding this comment.
Looks good @d-bernat, just some minor comments/suggestions 👍
gnespolino
approved these changes
Aug 3, 2022
gnespolino
left a comment
Contributor
There was a problem hiding this comment.
Looks good, I left just a suggestion for a small possible refactoring, feel free to implement if you think it's good
|
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #11384 +/- ##
============================================
+ Coverage 63.15% 63.24% +0.09%
- Complexity 27252 27292 +40
============================================
Files 3195 3195
Lines 112650 112722 +72
Branches 13244 13249 +5
============================================
+ Hits 71143 71292 +149
+ Misses 35396 35320 -76
+ Partials 6111 6110 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








please see: https://jira.dhis2.org/browse/DHIS2-13528