Replace vite-tsconfig-paths with native Vite resolution - #1266
Merged
Conversation
Co-authored-by: Codex <codex@openai.com>
|
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
This changes core build/test tooling resolution behavior and the PR notes frontend build/type-check/tests were not run in the current environment.
Pull request overview
This PR removes the vite-tsconfig-paths plugin from the Menu frontend (ui/menu-website) and switches both Vite and Storybook’s Vite builder to Vite v8’s native resolve.tsconfigPaths support, to keep TypeScript path aliases (e.g. @/* and @storybook-config/*) resolving without the plugin.
Changes:
- Enable native
resolve.tsconfigPathsinvite.config.tsand Storybook’sviteFinaloverride. - Remove
vite-tsconfig-pathsfrompackage.jsonand clean uppnpm-lock.yamlentries.
File summaries
| File | Description |
|---|---|
| ui/menu-website/vite.config.ts | Removes vite-tsconfig-paths plugin usage and enables resolve.tsconfigPaths: true for native TS path alias resolution. |
| ui/menu-website/.storybook/main.ts | Removes vite-tsconfig-paths plugin usage and enables config.resolve.tsconfigPaths = true for Storybook’s Vite builder. |
| ui/menu-website/package.json | Drops the vite-tsconfig-paths dependency. |
| ui/menu-website/pnpm-lock.yaml | Removes lockfile entries for vite-tsconfig-paths and its transitive dependencies. |
Review details
Files not reviewed (1)
- ui/menu-website/pnpm-lock.yaml: Generated file
- Files reviewed: 3/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the deprecated
vite-tsconfig-pathsplugin with Vite's native tsconfig path resolution.Closes #1265
Changes
ui/menu-website/vite.config.ts— enableresolve.tsconfigPaths: trueand remove the plugin.ui/menu-website/.storybook/main.ts— enable native tsconfig path resolution and remove the Storybook plugin setup.ui/menu-website/package.json— remove thevite-tsconfig-pathsdependency.ui/menu-website/pnpm-lock.yaml— remove the dependency and its now-unused lockfile entries.This removes the Vite warning while preserving the existing tsconfig alias resolution used by the frontend and Storybook.
Verification
pnpm install --frozen-lockfile— passed; lockfile is up to date and dependencies were installed.git diff --check— passed.pnpm-lock.yaml.vite-tsconfig-pathsreferences remain in the frontend configuration, package manifest, or lockfile.vue-tsc, unit tests, Storybook tests, ESLint, and Vite build — blocked before project code loaded by an environment dependency-tree problem: the installed tree reports anentitiesCommonJS/ESM mismatch and a missing@babel/code-framemodule. These are package-runtime errors, not test failures from this change.