fix: make asset canister reserve space when saving to stable storage - #4036
Merged
13 commits merged intoDec 11, 2024
Merged
Conversation
added 12 commits
December 11, 2024 04:37
ghost
marked this pull request as ready for review
December 11, 2024 18:12
ghost
self-requested a review
as a code owner
December 11, 2024 18:12
lwshang
previously approved these changes
Dec 11, 2024
ghost
enabled auto-merge (squash)
December 11, 2024 19:13
lwshang
approved these changes
Dec 11, 2024
ghost
deleted the
ens/sdk-1827-upgrade-asset-canister
branch
December 11, 2024 19:49
rikonor
pushed a commit
that referenced
this pull request
Feb 3, 2025
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the asset canister estimate the size of the data to be serialized to stable memory, and reserve that much space for the ValueSerializer's buffer.
The portal fails to upgrade from dfx 0.22.0 with an opaque
Canister trapped: unreachable error.This turns out to be the chain of events:
ic_cdk::storage::stable_save, which in turn callscandid::write_args, which constructs an IDLBuilder and serializes the data onto it.Vec<u8>with 0 capacity.Part of https://dfinity.atlassian.net/browse/SDK-1827
How Has This Been Tested?
Create a new project and add the portal's data to its frontend canister. I ended up reading the data from the portal canister.
In one shell, run the following:
In another shell, with the dfx under test on the PATH, run the following:
Checklist: