refactor: remove output_idl_path from <type>CanisterInfo types - #3828
Merged
13 commits merged intoJul 15, 2024
Merged
Conversation
added 13 commits
July 10, 2024 12:22
ghost
self-requested a review
as a code owner
July 12, 2024 21:40
viviveevee
approved these changes
Jul 15, 2024
ghost
deleted the
ens/poc-unify-output-idl-path
branch
July 15, 2024 14:54
rikonor
pushed a commit
that referenced
this pull request
Feb 3, 2025
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
CanisterInfo.output_idl_pathand remove it from MotokoCanisterInfo, RustCanisterInfo, and so forth, and removeCustomBuilderExtra.candid.Changed the return type of
CanisterInfo.get_output_idl_path()fromOption<PathBuf>to&Pathsince it is guaranteed to be set.The motivation is to move in the direction of removing all of the *CanisterInfo types, instead having properties on CanisterInfo.
How Has This Been Tested?
Covered by existing e2e tests
Checklist: