chore: upgrade ic-wasm/walrus to build memory64 - #3827
Merged
Conversation
lwshang
marked this pull request as ready for review
July 10, 2024 16:05
lwshang
enabled auto-merge (squash)
July 10, 2024 16:20
adamspofford-dfinity
approved these changes
Jul 10, 2024
rikonor
pushed a commit
that referenced
this pull request
Feb 3, 2025
* chore: upgrade ic-wasm and walrus to support wasm64 * e2e test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgraded dependencies:
ic-wasmandwalrusto enabledfxpost-processing memory64 canister Wasm module (shrink, optimize, etc) during a later stage of canister building.Because of indirect dependencies (wasm-tools crates, e.g. wasmparser), the MSRV has to be raised to 1.76.0.
How Has This Been Tested?
Added an test case in e2e build.bash. It only checks that
dfx buildworks with memory64 canister.Without upgrading the dependencies, the test case result in following error:
Notice
This is not a complete support of memory64 canister. We will make it in future PRs which:
Checklist:
I have edited the CHANGELOG accordingly.I have made corresponding changes to the documentation.