Skip to content

chore!: --with-cycles requires --wallet is enforced earlier - #3817

Merged
viviveevee merged 3 commits into
masterfrom
severin/explicit-wallet-requirement
Jul 3, 2024
Merged

chore!: --with-cycles requires --wallet is enforced earlier#3817
viviveevee merged 3 commits into
masterfrom
severin/explicit-wallet-requirement

Conversation

@viviveevee

@viviveevee viviveevee commented Jul 3, 2024

Copy link
Copy Markdown
Contributor

Description

Internal complaint:

If I pass arguments that won't work, such as --with-cycles without --wallet, it would be nice to get an error about that before walking though the entire interactive wizard.

With this change the user will see the error message instantly. The requirement is not new, just enforced at an earlier point in time.

How Has This Been Tested?

Tested manually

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@viviveevee
viviveevee marked this pull request as ready for review July 3, 2024 10:00
@viviveevee
viviveevee requested a review from a team as a code owner July 3, 2024 10:00
@viviveevee
viviveevee enabled auto-merge (squash) July 3, 2024 10:00
@viviveevee
viviveevee merged commit e599de6 into master Jul 3, 2024
@viviveevee
viviveevee deleted the severin/explicit-wallet-requirement branch July 3, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant