refactor: convert extension install to async - #3815
Merged
2 commits merged intoJul 2, 2024
Merged
Conversation
ghost
self-requested a review
as a code owner
July 1, 2024 23:22
viviveevee
approved these changes
Jul 2, 2024
ghost
enabled auto-merge (squash)
July 2, 2024 14:10
ghost
deleted the
ens/extension-install-async
branch
July 2, 2024 15:04
rikonor
pushed a commit
that referenced
this pull request
Feb 3, 2025
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upcoming changes to extension dependency management use retries and async. This PR updates existing code to use async. It makes minimal changes to compatibility_matrix.rs since it will soon be deleted.
How Has This Been Tested?
Covered by CI, and also ran
cargo build && dfx cache delete && dfx cache install && dfx extension install nns(fails as expected due to no entry in compatibility matrix) and thendfx extension install --version 0.3.1Checklist: