chore!: enforce minimum password length - #3808
Merged
Merged
Conversation
viviveevee
marked this pull request as ready for review
June 26, 2024 08:39
viviveevee
enabled auto-merge (squash)
June 26, 2024 08:39
Co-authored-by: Adam Spofford <93943719+adamspofford-dfinity@users.noreply.github.com>
adamspofford-dfinity
approved these changes
Jun 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Weak passwords can be easily cracked by attackers using brute force or dictionary attacks. This would cause the PEM files to be decrypted, making the passwords ineffective.
This PR creates a password policy that enforces a minimum length (more than 8 characters, see NIST guidelines).
Fixes FOLLOW-1579
How Has This Been Tested?
Check of new identities covered by new e2e
Manually tested that pre-existing identities keep working, even if the password is too short
Checklist: