feat: type definitions for extension dependencies and dependencies.json - #3807
Merged
8 commits merged intoJun 28, 2024
Merged
Conversation
ghost
self-requested a review
as a code owner
June 26, 2024 00:01
ghost
enabled auto-merge (squash)
June 26, 2024 17:17
viviveevee
approved these changes
Jun 27, 2024
ghost
deleted the
ens/sdk-1754-extension-dependencies
branch
June 28, 2024 17:17
rikonor
pushed a commit
that referenced
this pull request
Feb 3, 2025
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added type information for dependencies.json, and to the
dependenciesfield in extension.json (that it's a SemVer version requirement, expressed as a String in JSON). Nothing makes use of the new type for dependencies.json, nor of the pre-existing dependencies field in the extension manifest.Added
dfx schema --for extension-dependenciesAdded a table to the CLI docs to better describe what the different schemas correspond to.
Fixes https://dfinity.atlassian.net/browse/SDK-1754
How Has This Been Tested?
Added/updated unit tests
Checklist: