feat: require all PRs to update JSON schema if changed - #3803
Merged
9 commits merged intoJun 25, 2024
Merged
Conversation
ghost
changed the title
ghost
marked this pull request as ready for review
June 25, 2024 21:18
ghost
self-requested a review
as a code owner
June 25, 2024 21:18
ghost
approved these changes
Jun 25, 2024
ghost
deleted the
ens/fail-if-schema-docs-need-update
branch
June 25, 2024 21:22
rikonor
pushed a commit
that referenced
this pull request
Feb 3, 2025
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The update-docs workflow doesn't work (skips itself) for external PRs.
Make it fail any PR if any of the schema command outputs changed and the changes are not included in the PR, rather than pushing a commit to update them.
This way it will work on external PRs too, and we can make it a required status.
How Has This Been Tested?
The following PR makes a schema change: #3805
Checklist: