feat(icx-asset): add --no-delete option to sync command - #3768
Merged
Conversation
ghost
reviewed
May 28, 2024
ghost
approved these changes
May 28, 2024
Co-authored-by: Eric Swanson <64809312+ericswanson-dfinity@users.noreply.github.com>
rikonor
pushed a commit
that referenced
this pull request
Feb 3, 2025
* add --no-delete option to icx-asset sync * fix sync doc * Update e2e/tests-icx-asset/icx-asset.bash Co-authored-by: Eric Swanson <64809312+ericswanson-dfinity@users.noreply.github.com> --------- Co-authored-by: Eric Swanson <64809312+ericswanson-dfinity@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds --no-delete option to support the use case where the asset canister should keep all old assets.
How Has This Been Tested?
I added a new e2e test to e2e/tests-icx-asset/icx-asset.bash
Checklist: