perf: improve sync command performance - #3766
Merged
Merged
Conversation
olaszakos
changed the title
olaszakos
changed the title
olaszakos
marked this pull request as ready for review
May 23, 2024 10:04
olaszakos
changed the title
ghost
approved these changes
May 24, 2024
ghost
approved these changes
May 24, 2024
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Please add a note to the changelog. This kind of performance improvement is exciting!
olaszakos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR has the following changes:
icx-asset: Support log levels, and default toinfoHow Has This Been Tested?
I have not added any new tests, we are using this already with
icx-asset syncfor dfinity/portal PR preview deployments.Deployment time has gone down from ~40m to <10m.
Checklist: