feat: align, rather than indent, error causes - #3736
Merged
11 commits merged intoMay 2, 2024
Merged
Conversation
ghost
marked this pull request as draft
May 2, 2024 19:37
lwshang
approved these changes
May 2, 2024
added 2 commits
May 2, 2024 12:59
ghost
marked this pull request as ready for review
May 2, 2024 20:02
ghost
enabled auto-merge (squash)
May 2, 2024 20:44
ghost
deleted the
ens/error-output
branch
May 2, 2024 21:49
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rather than increasing indentation, dfx now displays each error cause on its own line.
Also changed error types to report error causes as causes, rather than embedding their error cause in the error text.
Before:
After:
How Has This Been Tested?
..
Checklist: