feat: Update agent to dac18df and add wasm_memory_limit support - #3727
Merged
Conversation
adamspofford-dfinity
marked this pull request as ready for review
April 25, 2024 14:17
adamspofford-dfinity
requested review from
a team and
chenyan-dfinity
as code owners
April 25, 2024 14:17
lwshang
reviewed
Apr 25, 2024
lwshang
reviewed
Apr 25, 2024
lwshang
requested changes
Apr 25, 2024
lwshang
left a comment
lwshang
left a comment
Contributor
There was a problem hiding this comment.
A few suggestions:
- Rename the PR title. It is far beyond upgrade agent-rs dependency.
- Add tests
adamspofford-dfinity
changed the title
wasm_memory_limit support
lwshang
reviewed
Apr 26, 2024
lwshang
reviewed
Apr 26, 2024
lwshang
self-requested a review
April 26, 2024 17:13
lwshang
approved these changes
Apr 26, 2024
ghost
approved these changes
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the new
wasm_memory_limitcanister setting.