fix: skip Matomo tracking on all localhost subdomains - #184
Merged
Conversation
aterga
pushed a commit
that referenced
this pull request
Sep 2, 2026
The caution said an app publishing no manifest "is still resolved and described, but none of its canisters is read or called". Two problems, both raised in review of the companion Terms change. "None of its canisters is read or called" overclaims. Discovery is HTTPS requests to the app's origin, and those are served by the app's own frontend asset canister through the gateway; the x-ic-canister-id header is the gateway naming the canister that answered. The claim is true of the calls ICP MCP makes to a canister, which is what the sentence now says. "Resolved and described" also said nothing a reader could act on. The caution now names the discovery sources a developer would recognise from their own app (the gateway header, /env.json, the JS bundle) and states the consequence #184's own scope note draws: those candidates can no longer be confirmed, so a manifest is the only route from an app to a canister an agent can use. That is the concrete cost of not publishing, which is the thing this caution exists to convey. Matches App Operator Terms sections 4 and 7 as revised in dfinity/internetcomputer-org#97 (60ef171). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xpg83AWtkQo34jbMxpX8WB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
endsWith("localhost")instead of!== "localhost"in the Matomo guard so tracking is also skipped on*.localhostsubdomains (e.g.myapp.localhost), which browsers treat as localSync recommendation
hand-written