feat: accept explicit asset content types from native embedders - #122
Closed
michaelmorandi wants to merge 2 commits into
Closed
feat: accept explicit asset content types from native embedders#122michaelmorandi wants to merge 2 commits into
michaelmorandi wants to merge 2 commits into
Conversation
Let native embedders pass media types as structured data instead of synthesizing a Netlify-style _headers control file. Co-authored-by: Cursor <cursoragent@cursor.com>
Verify the public sync entry point carries the declaration into the emitted CreateAsset operation. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Closing because CG-127 already provides the required behavior through CaLM's existing integration. The upstream API cleanup is not required for Layer 1 functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plan_project_with_content_typesandprepare_project_with_content_typesentry points toasset-prepsync_with_content_typestosync-corewhile preserving the existingsyncAPI_headerscontent-type rules, without changing response headersThis lets native embedders pass media types as structured data instead of synthesizing a Netlify-style
_headersfile and parsing it back. Existing callers continue through the old entry points with an empty override map.Closes #120.
Supersedes #121, which GitHub closed when its cross-fork source branch was renamed.
Test plan
cargo test -p asset-prep(162 passed)cargo test -p sync-core(84 unit and 4 call-pattern tests passed)cargo build -p asset-prep --no-default-featurescargo clippy -p asset-prep -p sync-core --all-targetsMade with Cursor