Skip to content

refactor: error message and add app validate#1382

Merged
aFlyBird0 merged 1 commit into
mainfrom
refactor-struct-error-msg
Dec 27, 2022
Merged

refactor: error message and add app validate#1382
aFlyBird0 merged 1 commit into
mainfrom
refactor-struct-error-msg

Conversation

@steinliber

@steinliber steinliber commented Dec 26, 2022

Copy link
Copy Markdown

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • add validate for app config data
  • refactor validator to make error more clear

Related Issues

close #1381

New Behavior (screenshots if needed)

Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>

@daniel-hutao daniel-hutao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daniel-hutao

Copy link
Copy Markdown
Member

@KeHaohaoke Please help to fix the ci error. It seems like a configuration issue with build machine.

@aFlyBird0 aFlyBird0 merged commit b35405a into main Dec 27, 2022
@daniel-hutao daniel-hutao deleted the refactor-struct-error-msg branch February 4, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🍀 Proposal: add app validator and format struct error

4 participants