|
$this->client = new \GuzzleHttp\Client(); |
I forked your project because I needed to rapidly customize your client and Laravel solution for a private project. Along the way I discovered a performance issue that occurs when using scout:import on a large model (in excess if 1M records). Every couple hundred or so write operations, I would get one of two errors:
- A CURL-level error, server timeout, e.g., "
- A PHP error about exceeding system limits on open file handles, e.g., "PHP Fatal error: Uncaught ErrorException: fopen(php://stderr): failed to open stream: operation failed in /Users/aaron/repos/c21-access/vendor/symfony/console/Output/ConsoleOutput.php:157"
Both of these problems lead me to debugging the application of Guzzle, ultimately leading to me moving the Guzzle client instantiation inside ApiCall to a static context, like:
private static $client;
protected function getClient()
{
return self::$client ? self::$client : (self::$client = $this->initClient());
}
protected function initClient()
{
return new GuzzleHttp\Client();
}Also worth noting that I downgraded the Guzzle dependency to ^6.3, which is what I require for my Laravel project. Whether or not the above issue with connections and/or file handles is caused by the downgrade isn't something I have time to analyze, but I wasn't able to find any reference to Guzzle specifically causing the above errors.
My dev machine is a Mac (macOS 10.15.6) running PHP 7.3.8.
typesense-php/src/ApiCall.php
Line 64 in c431933
I forked your project because I needed to rapidly customize your client and Laravel solution for a private project. Along the way I discovered a performance issue that occurs when using
scout:importon a large model (in excess if 1M records). Every couple hundred or so write operations, I would get one of two errors:Both of these problems lead me to debugging the application of Guzzle, ultimately leading to me moving the Guzzle client instantiation inside
ApiCallto a static context, like:Also worth noting that I downgraded the Guzzle dependency to
^6.3, which is what I require for my Laravel project. Whether or not the above issue with connections and/or file handles is caused by the downgrade isn't something I have time to analyze, but I wasn't able to find any reference to Guzzle specifically causing the above errors.My dev machine is a Mac (macOS 10.15.6) running PHP 7.3.8.