Skip to content

chore: cancel old in-progress CI workflows - #13811

Merged
littledivy merged 1 commit into
denoland:mainfrom
littledivy:greener-ci
Mar 2, 2022
Merged

chore: cancel old in-progress CI workflows#13811
littledivy merged 1 commit into
denoland:mainfrom
littledivy:greener-ci

Conversation

@littledivy

Copy link
Copy Markdown
Member

@kt3k kt3k left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@lucacasonato lucacasonato left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not do this on main? On main we want CI for every commit so we get all the canary releases.

@kt3k

kt3k commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

@lucacasonato
github doc says github.head_ref is only defined on pull_request events. So the expression ${{ github.head_ref || github.run_id }} should fallback to github.run_id (unique for each run) at push event, and won't prevent the main build (to my understanding)

@littledivy

Copy link
Copy Markdown
Member Author

Yup, This won't affect main since concurrency group github.run_id is always unique

@lucacasonato

Copy link
Copy Markdown
Contributor

One note: this does make committing multiple commits to find flaky tests more difficult.

@bartlomieju

Copy link
Copy Markdown
Member

One note: this does make committing multiple commits to find flaky tests more difficult.

Yeah basically in such case we'll need to push empty commit after the previous one finished. Let's see how it works, but I'm skeptical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants