Skip to content

Refine _cuda_device_count logic - #222

Merged
drcege merged 4 commits into
mainfrom
fix/cuda
Mar 6, 2024
Merged

Refine _cuda_device_count logic#222
drcege merged 4 commits into
mainfrom
fix/cuda

Conversation

@drcege

@drcege drcege commented Feb 29, 2024

Copy link
Copy Markdown
Collaborator
  • When torch is installed, we can utilize torch.cuda.device_count() to respect CUDA_VISIBLE_DEVICES.
  • Otherwise, it is non-trivial and prone to errors to manually parse CUDA_VISIBLE_DEVICES, so just ignore it for now.

@drcege drcege added the bug Something isn't working label Feb 29, 2024
@drcege drcege self-assigned this Feb 29, 2024
@drcege drcege linked an issue Feb 29, 2024 that may be closed by this pull request
[MM] speed up OPs using hf models (clip, ...) #199
Closed
zhijianma
zhijianma approved these changes Mar 6, 2024
View reviewed changes

@zhijianma zhijianma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drcege
drcege merged commit e2238e5 into main Mar 6, 2024
@drcege
drcege deleted the fix/cuda branch March 11, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhijianma zhijianma zhijianma approved these changes
@HYLcool HYLcool Awaiting requested review from HYLcool
@chenhesen chenhesen Awaiting requested review from chenhesen
@BeachWang BeachWang Awaiting requested review from BeachWang
@yxdyc yxdyc Awaiting requested review from yxdyc

Assignees

@drcege drcege

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MM] speed up OPs using hf models (clip, ...)

2 participants

@drcege @zhijianma